From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 157D8B8ACF
for <pve-devel@lists.proxmox.com>; Wed, 6 Dec 2023 10:46:40 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E19D337070
for <pve-devel@lists.proxmox.com>; Wed, 6 Dec 2023 10:46:09 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 6 Dec 2023 10:46:08 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 71C4E42505
for <pve-devel@lists.proxmox.com>; Wed, 6 Dec 2023 10:46:08 +0100 (CET)
Message-ID: <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com>
Date: Wed, 6 Dec 2023 10:46:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
References: <20231129132117.217210-1-m.sandoval@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20231129132117.217210-1-m.sandoval@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.018 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as
translatable
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2023 09:46:40 -0000
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management Environment
i don't think/believe this should be translated
into other languages as a standalone word
rest looks fine to me though
On 11/29/23 14:21, Maximiliano Sandoval wrote:
> Note that ACME is already in 3 translatable strings, a similar remark
> applies to N/A which is already translated in many languages.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/node/DNSView.js | 2 +-
> src/panel/ACMEDomains.js | 2 +-
> src/panel/DiskList.js | 6 +++---
> src/window/NotificationMatcherEdit.js | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/node/DNSView.js b/src/node/DNSView.js
> index 4782f9c..d2a784f 100644
> --- a/src/node/DNSView.js
> +++ b/src/node/DNSView.js
> @@ -21,7 +21,7 @@ Ext.define('Proxmox.node.DNSView', {
> run_editor: run_editor,
> rows: {
> search: {
> - header: 'Search domain',
> + header: gettext('Search domain'),
> required: true,
> renderer: Ext.htmlEncode,
> },
> diff --git a/src/panel/ACMEDomains.js b/src/panel/ACMEDomains.js
> index a7fb088..9e2e34b 100644
> --- a/src/panel/ACMEDomains.js
> +++ b/src/panel/ACMEDomains.js
> @@ -10,7 +10,7 @@ Ext.define('Proxmox.panel.ACMEDomains', {
> mixins: ['Proxmox.Mixin.CBind'],
>
> margin: '10 0 0 0',
> - title: 'ACME',
> + title: gettext('ACME'),
>
> emptyText: gettext('No Domains configured'),
>
> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
> index 4808f5c..dc10ac5 100644
> --- a/src/panel/DiskList.js
> +++ b/src/panel/DiskList.js
> @@ -325,14 +325,14 @@ Ext.define('Proxmox.DiskList', {
> dataIndex: 'status',
> },
> {
> - header: 'Mounted',
> + header: gettext('Mounted'),
> width: 60,
> align: 'right',
> renderer: Proxmox.Utils.format_boolean,
> dataIndex: 'mounted',
> },
> {
> - header: 'Wearout',
> + header: gettext('Wearout'),
> width: 90,
> sortable: true,
> align: 'right',
> @@ -341,7 +341,7 @@ Ext.define('Proxmox.DiskList', {
> if (Ext.isNumeric(value)) {
> return (100 - value).toString() + '%';
> }
> - return 'N/A';
> + return gettext('N/A');
> },
> },
> ],
> diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
> index f88576a..e717ad7 100644
> --- a/src/window/NotificationMatcherEdit.js
> +++ b/src/window/NotificationMatcherEdit.js
> @@ -1025,7 +1025,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleSettings', {
> ],
> },
> {
> - fieldLabel: 'Match Type',
> + fieldLabel: gettext('Match Type'),
> xtype: 'proxmoxKVComboBox',
> reference: 'type',
> isFormField: false,