From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 86D4D1FF13F for ; Thu, 07 May 2026 09:05:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1CDDB921; Thu, 7 May 2026 09:05:54 +0200 (CEST) Message-ID: <50d452d1-4437-44d9-8719-3317679b63e7@proxmox.com> Date: Thu, 7 May 2026 09:05:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260507065517.237996-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260507065517.237996-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778137443195 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BDVYFWMCCFVQTFAMUR6RZQ64YT3CU43H X-Message-ID-Hash: BDVYFWMCCFVQTFAMUR6RZQ64YT3CU43H X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: d.riley@proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: yep, I overlooked this, patch works Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 5/7/26 8:53 AM, Arthur Bied-Charreton wrote: > Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a > new OSPanel component, but left the onGetValues hook that appends the > `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer > appears. > > As a result, creating a Windows guest with the "Add additional drive for > VirtIO drivers" checkbox enabled fails due to the missing explicit > media=cdrom. > > Move the now-unreachable onGetValues logic from OSTypeInputPanel onto > the wrapper inputpanel that now actually holds the ISO selector in > OSPanel. > > Reported-by: David Riley > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/qemu/OSPanel.js | 10 ++++++++++ > www/manager6/qemu/OSTypeEdit.js | 11 ----------- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js > index be0e5b85..556ad4c3 100644 > --- a/www/manager6/qemu/OSPanel.js > +++ b/www/manager6/qemu/OSPanel.js > @@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', { > }, > { > xtype: 'inputpanel', > + onGetValues: function (values) { > + if (values.ide0) { > + let drive = { > + media: 'cdrom', > + file: values.ide0, > + }; > + values.ide0 = PVE.Parser.printQemuDrive(drive); > + } > + return values; > + }, > items: [ > { > xtype: 'proxmoxcheckbox', > diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js > index 5c79164f..5a2f2ae6 100644 > --- a/www/manager6/qemu/OSTypeEdit.js > +++ b/www/manager6/qemu/OSTypeEdit.js > @@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', { > } > }, > > - onGetValues: function (values) { > - if (values.ide0) { > - let drive = { > - media: 'cdrom', > - file: values.ide0, > - }; > - values.ide0 = PVE.Parser.printQemuDrive(drive); > - } > - return values; > - }, > - > initComponent: function () { > var me = this; >