From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2328E1FF187 for ; Mon, 25 Aug 2025 12:50:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C3DB1005D; Mon, 25 Aug 2025 12:50:27 +0200 (CEST) Message-ID: <50c18248-b735-4cb0-a2dd-aab461372108@proxmox.com> Date: Mon, 25 Aug 2025 12:49:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Stefan Hanreich , Proxmox Datacenter Manager development discussion References: <20250825081042.797559-1-d.csapak@proxmox.com> <20250825081042.797559-2-d.csapak@proxmox.com> <5636a6b0-c11f-49fc-92d2-9a6b3829b2dc@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <5636a6b0-c11f-49fc-92d2-9a6b3829b2dc@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756118990828 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 1/8] server: task cache: treat a limit of 0 as unbounded X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 8/25/25 11:55 AM, Stefan Hanreich wrote: > > > On 8/25/25 10:10 AM, Dominik Csapak wrote: >> like we do in our other products e.g. like PBS >> This way, one can specify a way to return *all* tasks. >> >> Signed-off-by: Dominik Csapak >> --- >> server/src/remote_tasks/mod.rs | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/server/src/remote_tasks/mod.rs b/server/src/remote_tasks/mod.rs >> index 63a279a..91b79c1 100644 >> --- a/server/src/remote_tasks/mod.rs >> +++ b/server/src/remote_tasks/mod.rs >> @@ -36,6 +36,11 @@ pub async fn get_tasks(filters: TaskFilters) -> Result, Error> >> GetTasks::All >> }; >> >> + let limit = match filters.limit { >> + 0 => usize::MAX, >> + limit => limit as usize, >> + }; >> + > > is this a usize because of backwards / API compatibility? Otherwise, > wouldn't an Option be preferrable? > i think for the taskfilters it's desireable to have a somehwat sane default limit in the api (which is currently '50') and make the 'show all tasks' an explicit case, otherwise people rather easily get all tasks returned, and that can be many but IMHO this is not set in stone, if we want to return all tasks by default we could change it of course since we reuse the `TaskFilters` struct this would also affect the pdm node tasks themselves. >> let returned_tasks = cache >> .get_tasks(which)? >> .filter_map(|task| { >> @@ -105,7 +110,7 @@ pub async fn get_tasks(filters: TaskFilters) -> Result, Error> >> true >> }) >> .skip(filters.start as usize) >> - .take(filters.limit as usize) >> + .take(limit) >> .collect(); >> >> Ok(returned_tasks) > > _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel