From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 8FA6B1FF0E0
	for <inbox@lore.proxmox.com>; Thu, 09 Jul 2026 09:39:20 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id A576A2144D;
	Thu, 09 Jul 2026 09:39:19 +0200 (CEST)
Message-ID: <4f303ee8-64aa-4cff-9bed-102ec12db005@proxmox.com>
Date: Thu, 9 Jul 2026 09:39:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: applied: [PATCH proxmox-backup] fix #5971: tape: don't warn on custom
 MAM attribute write failures
To: Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20260702123910.3975440-1-d.csapak@proxmox.com>
Content-Language: en-US
From: Dietmar Maurer <dietmar@proxmox.com>
In-Reply-To: <20260702123910.3975440-1-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783582744602
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.001 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: WF6VEWWZJSXHCYN6D4JRKWI3JXMONYDT
X-Message-ID-Hash: WF6VEWWZJSXHCYN6D4JRKWI3JXMONYDT
X-MailFrom: dietmar@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

applied

On 7/2/26 2:39 PM, Dominik Csapak wrote:
> We don't actually use the MAM attributes for anything substantial, it's
> just informational. This makes these warnings too noisy for drives that
> don't support them, so reduce them to info level.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   pbs-tape/src/sg_tape.rs | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs
> index 04914e077..3e6aac685 100644
> --- a/pbs-tape/src/sg_tape.rs
> +++ b/pbs-tape/src/sg_tape.rs
> @@ -1192,7 +1192,7 @@ impl SgTape {
>   
>           for (id, data) in attribute_list {
>               if let Err(err) = write_mam_attribute(&mut self.file, id, data) {
> -                log::warn!("could not set MAM Attribute {id:x}: {err}");
> +                log::info!("could not set MAM Attribute {id:x}: {err}");
>               }
>           }
>       }
> @@ -1201,7 +1201,7 @@ impl SgTape {
>       fn clear_mam_attributes(&mut self) {
>           for attr in [0x08_00, 0x08_01, 0x08_02, 0x08_03, 0x08_08] {
>               if let Err(err) = write_mam_attribute(&mut self.file, attr, b"") {
> -                log::warn!("could not clear MAM attribute {attr:x}: {err}");
> +                log::info!("could not clear MAM attribute {attr:x}: {err}");
>               }
>           }
>       }