From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id A9AF06008C
 for <pve-devel@lists.proxmox.com>; Fri,  5 Feb 2021 13:20:49 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 8CF5E839E
 for <pve-devel@lists.proxmox.com>; Fri,  5 Feb 2021 13:20:19 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 19392838C
 for <pve-devel@lists.proxmox.com>; Fri,  5 Feb 2021 13:20:19 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CED7A461EA
 for <pve-devel@lists.proxmox.com>; Fri,  5 Feb 2021 13:20:18 +0100 (CET)
Message-ID: <4f2fd155-7f2c-101d-44a8-fd82305fd29f@proxmox.com>
Date: Fri, 5 Feb 2021 13:20:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101
 Thunderbird/86.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Hannes Laimer <h.laimer@proxmox.com>
References: <20210205103538.742007-1-h.laimer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210205103538.742007-1-h.laimer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.028 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.182 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [nodes.pm]
Subject: Re: [pve-devel] [PATCH pve-manager 0/2] add pause bulk action
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 12:20:49 -0000

On 05.02.21 11:35, Hannes Laimer wrote:
> Add "Pause" to available bulk actions, only VMs can be paused(suspended).
> 

as mentioned off-list, this is not pause (or at least should not be), but
hibernation or also called suspension.

There exists also a pause in QEMU, which is just pausing running the guests,
without any state saving. Here we do not want to do that, this is seldom useful,
what we actually want to do is suspend to disk, so that the whole VM state
is saved to.

Please adapt the commit message and also the web interface, as mentioned
already off-list before you sent this!

> Hannes Laimer (2):
>   api2: add suspendall endpoint
>   ui: add "Bulk Pause" action to node
> 
>  PVE/API2/Nodes.pm               | 113 ++++++++++++++++++++++++++++++++
>  www/manager6/Utils.js           |   1 +
>  www/manager6/form/VMSelector.js |  10 +++
>  www/manager6/node/CmdMenu.js    |  15 +++++
>  www/manager6/node/Config.js     |  13 ++++
>  5 files changed, 152 insertions(+)
>