Re: [PATCH datacenter-manager v6 10/11] ui: pve: node selector: sort memory columns by usage not by memory size

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 05/10/2026 13:01, Dominik Csapak wrote:
> We only show the usage, so it makes sense to sort by that instead of the
> raw memory size value.
> 
> Use total_cmp for floats, which sorts (+/-)NaN/Infinity separate from
> finite values.


btw. and rather orthogonal to this, but it might be also nice to check
the some constraints here, like for example when using the selector for
selecting a CT/VM migration target, checking if the available memory on
the target is big enough to hold the to-be-moved guest. If not, or
resulting headroom is rather small we could show a hint, as there are lot
usage values where one cannot determine if the available memory amount
will be a hard blocker, especially if the guest is currently is not running
and one cannot determine its usage (plus KSM and other settings (one node
using zram or so while the other not). Maybe with a bit of headroom for the
node like say 0.5 to 1 GiB or so extra, absolute value as percents make not
much sense in memory headroom in practice, as its there to be used and 2%
of a 16 GiB system is basically always too small while 2% of a TiB system
is rather big with no relation for why a bigger systems needs a proportional
amount of more absolute head room (potentially with upper and lower
boundary), IMO; but I digress into details.

Also something I'd like to see in PVE in general.

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/widget/pve_node_selector.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/ui/src/widget/pve_node_selector.rs b/ui/src/widget/pve_node_selector.rs
> index d471780e..5882f532 100644
> --- a/ui/src/widget/pve_node_selector.rs
> +++ b/ui/src/widget/pve_node_selector.rs
> @@ -261,7 +261,11 @@ fn columns(show_memory: bool) -> Rc<Vec<DataTableHeader<PveNodeResource>>> {
>                      }
>                      html! {format!("{:.2}%", 100.0 * entry.mem as f64 / entry.maxmem as f64)}
>                  })
> -                .sorter(|a: &PveNodeResource, b: &PveNodeResource| a.mem.cmp(&b.mem))
> +                .sorter(|a: &PveNodeResource, b: &PveNodeResource| {
> +                    let a = (a.mem as f64) / (a.maxmem as f64);
> +                    let b = (b.mem as f64) / (b.maxmem as f64);
> +                    a.total_cmp(&b)
> +                })
>                  .into(),
>          );
>      }