From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 422C61FF0B0 for ; Tue, 27 Oct 2026 12:33:23 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EE09A208B1; Tue, 27 Oct 2026 12:33:22 +0100 (CET) Message-ID: <4e712d59-1aa8-47a0-a2d4-58bcaac878e7@proxmox.com> Date: Tue, 27 Oct 2026 12:33:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config To: Jonas Theisen , pbs-devel@lists.proxmox.com References: <20261022164343.353831-1-j.theisen@proxmox.com> <20261022164343.353831-2-j.theisen@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20261022164343.353831-2-j.theisen@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793100799659 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.498 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UPNSNSAMBW5C7TFGCYHJSPSHLI5TZFQG X-Message-ID-Hash: UPNSNSAMBW5C7TFGCYHJSPSHLI5TZFQG X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/22/26 6:44 PM, Jonas Theisen wrote: > To be able to en-/disable the respective jobs this patch adds the > "disable" field to the job config and the needed schema. > > This also adds the "gc_disable" parameter to the datastore config > to allow this type of job to be disabled. > > "disable" was chosen over "enable" to be consistent with the already > existing config and API endpoints for prune jobs. > > This commit also aligns the prune job config to make use of > the new schema but does not modify functionality. > > Signed-off-by: Jonas Theisen Does not compile since is_false() implementation is now missing, but does not apply on top of the series mentioned in the cover letter either. Maybe best if you just re-implement or cherry pick that patch?