From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 530BA1FF37F
	for <inbox@lore.proxmox.com>; Thu, 18 Apr 2024 12:16:53 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1FC4A1A0DF;
	Thu, 18 Apr 2024 12:16:53 +0200 (CEST)
Message-ID: <4e5145ba-abdc-499c-a748-027a0306d773@proxmox.com>
Date: Thu, 18 Apr 2024 12:16:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexander Zeidler <a.zeidler@proxmox.com>
References: <20240418091650.51366-1-a.zeidler@proxmox.com>
 <20240418091650.51366-6-a.zeidler@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <20240418091650.51366-6-a.zeidler@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.045 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com, report.pm]
Subject: Re: [pve-devel] [PATCH manager 6/7] report: add info about (un)used
 memory slots
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

I am not sure how often we actually need that information as it can add 
quite a bit of additional lines in the report in larger machines with 
many memory slots.

It might be better to keep that command in a cheatsheet to ask for it if 
actually needed instead of polluting the report :)

On  2024-04-18  11:16, Alexander Zeidler wrote:
> * to see if a RAM upgrade is slot/capacity-wise possible
> * to spot added/replaced RAM that may now be causing issues
> 
> 	Maximum Capacity: 2 TB
> 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> 	Size: No Module Installed
> 	Size: No Module Installed
> 	Size: No Module Installed
> 	Size: No Module Installed
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v2:
> * make regex stricter
> * reduce possible dmidecode output which is not needed here
> * reduce and clarify the printed information
> 
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062348.html
> 
> 
>   PVE/Report.pm | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 9d1b9b27..d9f81a0f 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -113,6 +113,7 @@ my $init_report_cmds = sub {
>   		'cd /sys/devices/virtual/dmi/id; grep -HT "" sys_vendor product_name product_version',
>   		'cd /sys/devices/virtual/dmi/id; grep -HT "" board_vendor board_name board_version',
>   		'dmidecode -t 0,3,32',
> +		'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | sed -Ez "s/\n(\tP[^\n]*)/\1/g" | sort',
>   		'lspci -nnk',
>   	    ],
>   	},


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel