From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9CC051FF0AF for ; Fri, 06 Nov 2026 13:11:17 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 586EC214BE; Fri, 06 Nov 2026 13:11:17 +0100 (CET) Message-ID: <4c8b9d8b-4405-4333-b11c-9c83099499c2@proxmox.com> Date: Fri, 6 Nov 2026 13:10:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: [PATCH firewall/proxmox-firewall 0/2] fix bridge-nf-call settings during upgrades and handover To: pve-devel@lists.proxmox.com References: <20261106112315.151144-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20261106112315.151144-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.291 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZGZZ27APLGF5DXXEF47V3GBB5K6KBZ4T X-Message-ID-Hash: ZGZZ27APLGF5DXXEF47V3GBB5K6KBZ4T X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: https://lore.proxmox.com/pve-devel/20261106121015.188115-1-s.hanreich@proxmox.com/T/#t On 11/6/26 12:23 PM, Stefan Hanreich wrote: > pve-firewall needs net.bridge.bridge-nf-call-ip{,6}tables set to 1, so > that bridged guest traffic passes through iptables and conntrack. It > sets them at runtime, while 10-pve.conf sets them to 0. Whenever the > sysctl.d configuration is re-applied, e.g. when systemd-sysctl is > restarted during a package upgrade, they drop back to 0 until the next > update round of pve-firewall, up to 10 seconds later. Conntrack misses > the bridged traffic in between, so packets of established connections > get dropped as invalid afterwards. > > The pve-firewall patch writes a drop-in to /run/sysctl.d while the > iptables based firewall is active, so re-applying the configuration > keeps the values at 1. > > The proxmox-firewall patch fixes a related issue when switching to the > nftables based firewall at runtime. It does not need the sysctls, but > nothing reset them either, so the host and cluster forward rules also > applied to bridged guest traffic until the next re-apply. It now > re-applies the configured values once when it takes over, which keeps > any override by the admin. > > > pve-firewall: > > Stefan Hanreich (1): > fix #8268: firewall: keep bridge-nf-call sysctls set on upgrade > > debian/control | 4 ++-- > src/PVE/Firewall.pm | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 35 insertions(+), 3 deletions(-) > > > proxmox-firewall: > > Stefan Hanreich (1): > service: re-apply bridge sysctls when taking over from pve-firewall > > proxmox-firewall/src/bin/proxmox-firewall.rs | 35 ++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > > Summary over all repositories: > 3 files changed, 70 insertions(+), 3 deletions(-) >