Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons

[David Riley <d.riley@proxmox.com>]

On 5/20/26 2:53 PM, Dominik Csapak wrote:
> i guess this could be ok if it works,
> but i really dislike having to add 1 to 2 attributes
> per passwordmanager... isn't the generic 'autocomplete=off' enough?
>
Tested this patch and the fix worked for me.
I'm using the bitwarden extension on firefox.
>
> On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote:
>> Password manager extensions scan every new <input> element. The flag
>> selector grid creates hundreds of radio buttons through its
>> widgetcolumn, causing the extension to peg the CPU while it checks each
>> one for autofill.
>>
>> Mark the radio inputs with autocomplete="off" and the extension-specific
>> ignore attributes so they are skipped during the scan.
>>
>> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
>> ---
>>   www/manager6/form/VMCPUFlagSelector.js | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
>> index ea20108d..f8d4caad 100644
>> --- a/www/manager6/form/VMCPUFlagSelector.js
>> +++ b/www/manager6/form/VMCPUFlagSelector.js
>> @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>>                           boxLabelAlign: 'before',
>>                           inputValue: '-',
>>                           isFormField: false,
>> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>>                       },
>>                       {
>>                           checked: true,
>>                           inputValue: '=',
>>                           isFormField: false,
>> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>>                       },
>>                       {
>>                           boxLabel: '+',
>>                           inputValue: '+',
>>                           isFormField: false,
>> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>>                       },
>>                   ],
>>               },
>
>
>
>
>