From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6557E1FF143 for ; Mon, 02 Feb 2026 11:03:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D21A32E8; Mon, 2 Feb 2026 11:03:32 +0100 (CET) Message-ID: <4b50c12d-5110-4ad0-9798-e6cc7f4b151e@proxmox.com> Date: Mon, 2 Feb 2026 11:02:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH v5 proxmox-backup 01/16] datastore: remove Arc from FixedIndexWriter To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260130164552.281581-1-r.obkircher@proxmox.com> <20260130164552.281581-2-r.obkircher@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260130164552.281581-2-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770026505701 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.252 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: INSAU2IOT5GJC2MIWYWWN3ETKOYLEBFU X-Message-ID-Hash: INSAU2IOT5GJC2MIWYWWN3ETKOYLEBFU X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/30/26 5:45 PM, Robert Obkircher wrote: > The ChunkStore reference can be safely removed, because it was only > needed for the base directory. As discussed previously in the context > of the DynamicIndexWriter [1], it is the callers responsibility to > ensure that the writer doesn't outlive any locks. > > This simplifies testing the writer, which would otherwise require a > workaround to avoid creating 65k directories. > > [1] https://lore.proxmox.com/pbs-devel/1761822027.sm41v71zmk.astroid@yuna.none/ > > Signed-off-by: Robert Obkircher > --- Changes look good to me, patch could already be applied IMO: Reviewed-by: Christian Ebner