From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 458671FF16F for ; Tue, 30 Sep 2025 14:35:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABA0E70AF; Tue, 30 Sep 2025 14:35:11 +0200 (CEST) Message-ID: <4ac305a2-5d44-48f9-9286-48a2520e4369@proxmox.com> Date: Tue, 30 Sep 2025 14:34:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Christian Ebner , Wolfgang Bumiller References: <20250930080207.111162-1-c.ebner@proxmox.com> <5jmcsjt7cdnnxghl3hxxfdph2m5euzydxrnpltt2vorp6o7b6s@6fu6j2jlsrqz> <448266d6-a81c-400e-bead-a8398801d694@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <448266d6-a81c-400e-bead-a8398801d694@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759235657511 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Am 30.09.25 um 14:19 schrieb Christian Ebner: > On 9/30/25 1:49 PM, Wolfgang Bumiller wrote: >> On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote: >>> This patches fix the ticket parsing when login to instances of PBS version 3 >>> or lower. For this, the current pve_compat flags for `Login` and `Client` >>> are refactored to be an extendable enum variant instead, adding the ticket >>> parsing backwards compatibility. In that compatibility mode, response parsing >>> of the ticket does not interpret the presence of the `ticket-info` field as the >>> ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4 >>> compatible parsing, as the client never used `http-only` tickets. >> >> I thought this field was introduced only with http-only tickets, so why >> is it not a reliable indicator and shouldn't *that* be fixed instead? > > I'm not so familiar with the actual code and the changes over time here, so that might as well be the case. FYI: Shannon is back at work tomorrow and this is not really _that_ pressing, so I'd wait at least until tomorrow to hopefully get some better rationale. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel