From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AD3579102D for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 11:19:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9411F33681 for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 11:19:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 11:19:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9CD45492C2 for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 11:19:35 +0100 (CET) Message-ID: <4abb3860-dc51-4a14-9f78-d64dc1ac6d09@proxmox.com> Date: Fri, 26 Jan 2024 11:19:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Hannes Duerr <h.duerr@proxmox.com> References: <20240110124549.160682-1-h.duerr@proxmox.com> From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20240110124549.160682-1-h.duerr@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, drive.pm, qemuserver.pm] Subject: [pve-devel] applied: [PATCH qemu-server v7 0/1] fix #4957: add vendor and product information passthrough for SCSI-Disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 26 Jan 2024 10:19:36 -0000 Am 10.01.24 um 13:45 schrieb Hannes Duerr: > qemu-server: > > Hannes Duerr (1): > fix #4957: add vendor and product information passthrough for > SCSI-Disks > > PVE/API2/Qemu.pm | 39 +++++++++++++++++++++++++++++++++++++++ > PVE/QemuServer.pm | 12 ++++++++++++ > PVE/QemuServer/Drive.pm | 24 ++++++++++++++++++++++++ > 3 files changed, 75 insertions(+) > > > Summary over all repositories: > 3 files changed, 75 insertions(+), 0 deletions(-) > applied, thanks! Squashed in a few style changes that didn't warrant a new version IMHO: - You can use up to 100 characters per line, no need to split function calls early, if they can fit that limit - The exception message should be for raised for the config option, not the sub-option, e.g. 'scsi0' instead of 'product' - Also fixed the style for the exception (missing trailing comma, indentation, message missing a space): > - product => "Passing of product information is only supported for". > - "'scsi-hd' and 'scsi-cd' devices (e.g. not pass-through)." > + $opt => "Passing of product information is only supported for 'scsi-hd' and " > + ."'scsi-cd' devices (e.g. not pass-through).",