From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 41B451FF164 for ; Fri, 23 May 2025 11:18:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7E691723B; Fri, 23 May 2025 11:18:41 +0200 (CEST) Message-ID: <49ae8bdf-912a-4a87-8290-f63ecef560e1@proxmox.com> Date: Fri, 23 May 2025 11:18:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "DERUMIER, Alexandre" , "pve-devel@lists.proxmox.com" References: <20250509141532.111458-1-f.ebner@proxmox.com> <20250509141532.111458-3-f.ebner@proxmox.com> <175dd76aa95365010c8448bdd15eddf30aa39641.camel@groupe-cyllene.com> <247b14e8-0915-461b-9eb7-c6acb83e762d@proxmox.com> <67db7959a03a391df39e9b5af24edc2bed48a21d.camel@groupe-cyllene.com> <30552bb9-70aa-49f1-8ff9-f8cad5f31d65@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC storage 1/3] plugin: add method to get qemu blockdevice options for volume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 23.05.25 um 11:15 schrieb DERUMIER, Alexandre: >>> Good point! I guess it's better to also do the activation in qemu- >>> server >>> then, so that we can match it up nicely without going over package >>> boundaries. > > Ok, I'll add the activate in qemu-server too > > > > Just found another bug: > > PVE/Storage.pm > > sub qemu_blockdev_options { > my ($cfg, $volid, $snapname) = @_; > > my ($storeid, $volname) = parse_volume_id($volid); > > > This fail with $volid=/dev/cdrom (with ide2:cdrom) > # got unexpected error: unable to parse volume ID 'cdrom' > > and maybe (not have tested it) , if user have configured manually dev > passthrough like : "scsi1: /dev/...." I intentionally do not handle CD-ROMs, qemu-server should be concerned with doing that. There is a comment about this ;) > + # The 'file' driver only works for regular files. The check below is taken from > + # block/file-posix.c:hdev_probe_device() in QEMU. Do not bother with detecting 'host_cdrom' > + # devices here, those are not managed by the storage layer. Best Regards, Fiona _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel