From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 1D25A61A31
for <pve-devel@lists.proxmox.com>; Tue, 18 Jan 2022 09:35:48 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1099922BAC
for <pve-devel@lists.proxmox.com>; Tue, 18 Jan 2022 09:35:48 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 6A17D22B9F
for <pve-devel@lists.proxmox.com>; Tue, 18 Jan 2022 09:35:44 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3DA6A446D1
for <pve-devel@lists.proxmox.com>; Tue, 18 Jan 2022 09:35:44 +0100 (CET)
Message-ID: <48c3e875-a4fb-a263-c4f2-49c21d6facec@proxmox.com>
Date: Tue, 18 Jan 2022 09:35:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.4.1
Content-Language: en-US
To: pve-devel@lists.proxmox.com,
=?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= <f.gruenbichler@proxmox.com>
References: <20220113100831.34113-1-f.ebner@proxmox.com>
<20220113100831.34113-5-f.ebner@proxmox.com>
<1642418050.f53h13is6j.astroid@nora.none>
From: Fabian Ebner <f.ebner@proxmox.com>
In-Reply-To: <1642418050.f53h13is6j.astroid@nora.none>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.415 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
POISEN_SPAM_PILL 0.1 Meta: its spam
POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes
POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com, nodes.pm]
Subject: Re: [pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf
endpoint
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2022 08:35:48 -0000
Am 17.01.22 um 16:38 schrieb Fabian Grünbichler:
> missing a reason why this is added to the generic node index, and not
> somewhere under qemu?
>
I suppose because having it under /nodes/{node}/qemu/ would imply having
it under /nodes/{node}/qemu/{vmid}/ (as we don't support having both
path/{regex} and path/static at the same time), but it doesn't depend on
any vmid?
> On January 13, 2022 11:08 am, Fabian Ebner wrote:
>> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
>> [split into its own patch + add to index]
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Needs dependency bump for qemu-server.
>>
>> Changes from v9:
>> * Add entry to /node/'s index.
>>
>> PVE/API2/Nodes.pm | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
>> index d57a1937..5f6208d5 100644
>> --- a/PVE/API2/Nodes.pm
>> +++ b/PVE/API2/Nodes.pm
>> @@ -49,6 +49,7 @@ use PVE::API2::LXC;
>> use PVE::API2::Network;
>> use PVE::API2::NodeConfig;
>> use PVE::API2::Qemu::CPU;
>> +use PVE::API2::Qemu::OVF;
>> use PVE::API2::Qemu;
>> use PVE::API2::Replication;
>> use PVE::API2::Services;
>> @@ -71,6 +72,11 @@ __PACKAGE__->register_method ({
>> path => 'qemu',
>> });
>>
>> +__PACKAGE__->register_method ({
>> + subclass => "PVE::API2::Qemu::OVF",
>> + path => 'readovf',
>> +});
>> +
>> __PACKAGE__->register_method ({
>> subclass => "PVE::API2::LXC",
>> path => 'lxc',
>> @@ -233,6 +239,7 @@ __PACKAGE__->register_method ({
>> { name => 'network' },
>> { name => 'qemu' },
>> { name => 'query-url-metadata' },
>> + { name => 'readovf' },
>> { name => 'replication' },
>> { name => 'report' },
>> { name => 'rrd' }, # fixme: remove?
>> --
>> 2.30.2
>>
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel