From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E0557589E for <pve-devel@lists.proxmox.com>; Thu, 24 Jun 2021 11:01:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03106155E2 for <pve-devel@lists.proxmox.com>; Thu, 24 Jun 2021 11:01:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5258F155D6 for <pve-devel@lists.proxmox.com>; Thu, 24 Jun 2021 11:01:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 19230442F3 for <pve-devel@lists.proxmox.com>; Thu, 24 Jun 2021 11:01:16 +0200 (CEST) Message-ID: <48ae22a7-a690-df42-b19f-2093bd2e8413@proxmox.com> Date: Thu, 24 Jun 2021 11:01:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= <f.gruenbichler@proxmox.com> References: <20210624072936.723195-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210624072936.723195-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.638 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH installer] network: sync option names with pve-common X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 24 Jun 2021 09:01:17 -0000 On 24.06.21 09:29, Fabian Gr=C3=BCnbichler wrote: > back in 2018, commit 1accc6da659d8a02dcf1c2a636749e6f48fb9c2d > "Inotify : write network config : use modern syntax for options" > changed pve-common's /etc/network/interfaces writer to prefer options > with '-' over those with '_'. >=20 > having the installer write the old variant makes any modification of th= e > vmbr0 interface via the API also change these three lines to the new > variant - so let's do it right from the start. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com> > --- > https://forum.proxmox.com/threads/wrong-elaboration-of-etc-network-inte= rface-by-proxmox-gui.91271/ >=20 > proxinstall | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > nice catch, applied, thanks!