From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8BA9C1FF17E for ; Thu, 13 Nov 2025 10:32:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 61E6F167E3; Thu, 13 Nov 2025 10:33:18 +0100 (CET) Message-ID: <47f31f03-2e9f-4342-bed9-be0570a2dc20@proxmox.com> Date: Thu, 13 Nov 2025 10:33:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20251110084417.173290-1-n.frey@proxmox.com> Content-Language: en-US From: Nicolas Frey In-Reply-To: <20251110084417.173290-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763026368479 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.811 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] superseded: [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Superseded-by: https://lore.proxmox.com/pbs-devel/20251113093118.195229-1-n.frey@proxmox.com/T/#t On 11/10/25 9:44 AM, Nicolas Frey wrote: > This patch series aims to expand on Dominik's series [0] written for > pbs 3, parallelizing chunk reads in `VerifyWorker` using a seperate > thread pool from the verification. > > The number of threads was previously hard-coded, but is now > configurable via the API and GUI with new properties called > `{read,verify}-threads`, similarly to tape backups. > > The number of threads should also be configurable through tuning > options or datastore config (as discussed by Chris & Thomas on list), > which can be added in a follow up patch series. > > In my local tests I measured the following speed difference: > verified a single snapshot with ~32 GiB (4x the RAM size) with 4 > cores (just changing the read threads) > > 1 thread: ~440MiB/s > 2 threads: ~780MiB/s > 4 threads: ~1140MiB/s > > [0] https://lore.proxmox.com/pbs-devel/20250707132706.2854973-1-d.csapak@proxmox.com/#t > > Changes since v2: > * split move to parallel handler into 2 seperate commits > * add constructor to `IndexVerifyState` and clean up nits > > Changes since v1, thanks to Chris: > * define dedicated schema for {worker,read,verify}-threads > * rebase proxmox-backup > * introduce new state struct `IndexVerifyState` to reduce the amount > of Arc clones and overall better bundling > * adjust update endpoint and UI to the new properties > > proxmox: > > Nicolas Frey (3): > pbs-api-types: add schema for {worker,read,verify}-threads > pbs-api-types: jobs: add {read,verify}-threads to > VerificationJobConfig > pbs-api-types: use worker-threads schema for TapeBackupJobSetup > > pbs-api-types/src/datastore.rs | 14 ++++++++++++++ > pbs-api-types/src/jobs.rs | 20 +++++++++++++++----- > 2 files changed, 29 insertions(+), 5 deletions(-) > > > proxmox-backup: > > Nicolas Frey (6): > api: verify: move chunk loading into parallel handler > api: verify: bundle parameters into new struct > api: verify: determine the number of threads to use with > {read,verify}-threads > api: verify: correct typo in comment > api: verify: add {read,verify}-threads to update endpoint > ui: verify: add option to set number of threads for job > > src/api2/admin/datastore.rs | 18 +++- > src/api2/backup/environment.rs | 2 +- > src/api2/config/verify.rs | 16 ++++ > src/backup/verify.rs | 164 +++++++++++++++++++++------------ > src/server/verify_job.rs | 7 +- > www/window/VerifyAll.js | 18 ++++ > www/window/VerifyJobEdit.js | 24 +++++ > 7 files changed, 185 insertions(+), 64 deletions(-) > > > Summary over all repositories: > 9 files changed, 214 insertions(+), 69 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel