From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 28B601FF141 for ; Mon, 13 Apr 2026 12:06:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0157F1EBD0; Mon, 13 Apr 2026 12:06:51 +0200 (CEST) Message-ID: <470c276f-1105-4442-aae5-a8aa404fff90@proxmox.com> Date: Mon, 13 Apr 2026 12:06:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v2 12/27] api: config: allow encryption key manipulation for sync job To: Thomas Lamprecht References: <20260411085154.1961287-1-t.lamprecht@proxmox.com> <20260411085154.1961287-6-t.lamprecht@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260411085154.1961287-6-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776074732176 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sync.rs] Message-ID-Hash: V5T6L32RT6SEZ3VZVAPXKZYLEFUDFCY7 X-Message-ID-Hash: V5T6L32RT6SEZ3VZVAPXKZYLEFUDFCY7 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/11/26 10:50 AM, Thomas Lamprecht wrote: > Am 10.04.26 um 18:54 schrieb Christian Ebner: >> diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs >> @@ -490,6 +511,16 @@ pub fn update_sync_job( >> >> + DeletableProperty::ActiveEncryptionKey => { >> + allow_remove_associated = data.active_encryption_key.is_none(); >> + keep_previous_key_as_associated(&data, &mut update.associated_key); >> + data.active_encryption_key = None; >> + } >> + DeletableProperty::AssociatedKey => { >> + if allow_remove_associated { >> + data.associated_key = None; >> + } >> + } > > nit: the silent drop of AssociatedKey deletion when ActiveEncryptionKey is also > being deleted in the same request could trip people up. At least worth a code > comment explaining the rationale. > > btw/nit: nice idea that the previous active key gets auto-promoted to > associated on rotation, but the user receives zero feedback about that - maybe > log it so users can more easily see what happened. Actually, after revisiting this I think one can do better here: Instead of not dropping the associated keys as requested, drop them and only re-add the previous active encryption key, which can temporarily be store instead of the allow_remove_associated flag, therefore also being independent from the loop order. So it can simply be associated below, if required.