From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 310A91FF0AB
	for <inbox@lore.proxmox.com>; Wed, 23 Sep 2026 11:06:06 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 5D2022157A;
	Wed, 23 Sep 2026 11:06:03 +0200 (CEST)
Message-ID: <4680ba6c-fd9e-47b3-b3b7-cc4ee97fca14@proxmox.com>
Date: Wed, 23 Sep 2026 11:05:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH manager] 8to9: adapt to changed signature of
 get_vm_machine()
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20260129132623.127384-1-f.ebner@proxmox.com>
Content-Language: en-US
In-Reply-To: <20260129132623.127384-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790154359254
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.516 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: ZNLFLP4ROF4K3CSUUJV3APA3OTZMBIH5
X-Message-ID-Hash: ZNLFLP4ROF4K3CSUUJV3APA3OTZMBIH5
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 29.01.26 um 2:25 PM schrieb Fiona Ebner:
> The signature change in qemu-server does not lead to any breakage,
> because the function still looks at $conf->{arch}. Still, it should be
> adapted.
> 
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Dependency bump for qemu-server needed!

Ping. Still applies and the bump is already covered now :)

> 
>  PVE/CLI/pve8to9.pm | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 0c4b2343..662ee943 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -931,7 +931,7 @@ my sub check_qemu_machine_versions {
>          my $conf = PVE::QemuConfig->load_config($vmid);
>  
>          # first, actually configured machine version
> -        my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch});
> +        my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf);
>          if (
>              PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
>              && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline)
> @@ -942,9 +942,7 @@ my sub check_qemu_machine_versions {
>          # second, if hibernated, running machine version
>          if ($conf->{vmstate}) {
>              my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
> -                $conf,
> -                $conf->{runningmachine},
> -                $conf->{arch},
> +                $conf, $conf->{runningmachine},
>              );
>              if (
>                  PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
> @@ -964,7 +962,6 @@ my sub check_qemu_machine_versions {
>                  my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
>                      $snap_conf,
>                      $snap_conf->{runningmachine},
> -                    $snap_conf->{arch},
>                  );
>                  if ( # no version means latest
>                      PVE::QemuServer::Machine::extract_version($machine_type)