From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F061B1FF16F for ; Tue, 30 Sep 2025 14:19:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5926268D3; Tue, 30 Sep 2025 14:19:32 +0200 (CEST) Message-ID: <448266d6-a81c-400e-bead-a8398801d694@proxmox.com> Date: Tue, 30 Sep 2025 14:19:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wolfgang Bumiller References: <20250930080207.111162-1-c.ebner@proxmox.com> <5jmcsjt7cdnnxghl3hxxfdph2m5euzydxrnpltt2vorp6o7b6s@6fu6j2jlsrqz> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <5jmcsjt7cdnnxghl3hxxfdph2m5euzydxrnpltt2vorp6o7b6s@6fu6j2jlsrqz> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759234748021 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 9/30/25 1:49 PM, Wolfgang Bumiller wrote: > On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote: >> This patches fix the ticket parsing when login to instances of PBS version 3 >> or lower. For this, the current pve_compat flags for `Login` and `Client` >> are refactored to be an extendable enum variant instead, adding the ticket >> parsing backwards compatibility. In that compatibility mode, response parsing >> of the ticket does not interpret the presence of the `ticket-info` field as the >> ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4 >> compatible parsing, as the client never used `http-only` tickets. > > I thought this field was introduced only with http-only tickets, so why > is it not a reliable indicator and shouldn't *that* be fixed instead? I'm not so familiar with the actual code and the changes over time here, so that might as well be the case. AFAIK there are however PBS 3.x versions out there which do return the field also on non http-only tickets, the changes introduced by [0] back in March. So it only would be required to backport/build based on this [1] patch for stable-3 then? However, older patch level versions would still not work regardless. [0] https://git.proxmox.com/?p=proxmox.git;a=commit;h=6a7f6317093285a1494c4ebace71c71697058587 [1] https://git.proxmox.com/?p=proxmox.git;a=commit;h=8d01d274231f5b7172b519104a8042f92ace8e1e _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel