From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 5BF51674AF
 for <pve-devel@lists.proxmox.com>; Tue, 12 Jan 2021 12:24:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 59F5C2408E
 for <pve-devel@lists.proxmox.com>; Tue, 12 Jan 2021 12:24:42 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id E1D7F24081
 for <pve-devel@lists.proxmox.com>; Tue, 12 Jan 2021 12:24:41 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB294448F0
 for <pve-devel@lists.proxmox.com>; Tue, 12 Jan 2021 12:24:41 +0100 (CET)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Hannes Laimer <h.laimer@proxmox.com>
References: <20210112110754.168177-1-h.laimer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <43ffecfe-494e-4b3a-dbfe-39fa880c1bf2@proxmox.com>
Date: Tue, 12 Jan 2021 12:24:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101
 Thunderbird/84.0
MIME-Version: 1.0
In-Reply-To: <20210112110754.168177-1-h.laimer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.318 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [qemu.pm]
Subject: Re: [pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm
 async close #2315
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2021 11:24:42 -0000

On 12.01.21 12:07, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> Resize is now done in a task.
> 
> v1 -> v2: pass code that should be executed correctly to fork_worker

yeah that looked weird in the v1, did not checked it and assumed
you tested the version you actually send at least once (please try do so
in the future).

Anyway, all other points I replied to v1 still apply to v2.

> 
>  PVE/API2/Qemu.pm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index e8de4ea..0c5d50c 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -3730,7 +3730,7 @@ __PACKAGE__->register_method({
>  	    },
>  	},
>      },
> -    returns => { type => 'null'},
> +    returns => { type => 'string'},
>      code => sub {
>          my ($param) = @_;
>  
> @@ -3816,9 +3816,10 @@ __PACKAGE__->register_method({
>  
>  	    PVE::QemuConfig->write_config($vmid, $conf);
>  	};
> -
> -        PVE::QemuConfig->lock_config($vmid, $updatefn);
> -        return;
> +	my $worker = sub {
> +	    PVE::QemuConfig->lock_config($vmid, $updatefn);
> +	};
> +	return $rpcenv->fork_worker('qmresize', $vmid, $authuser, $worker);
>      }});
>  
>  __PACKAGE__->register_method({
>