From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE6BB1FF191 for ; Tue, 21 Oct 2025 21:18:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 154C18B7D; Tue, 21 Oct 2025 21:18:31 +0200 (CEST) Message-ID: <4381330b-7db7-427e-b82a-653d10dd4aa5@proxmox.com> Date: Tue, 21 Oct 2025 21:18:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Lukas Wagner References: <20251017121009.212499-1-l.wagner@proxmox.com> <20251017121009.212499-12-l.wagner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251017121009.212499-12-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761074300870 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 11/13] ui: add remote update view X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Nice work overall, some things that I noticed inline. Am 17.10.25 um 14:10 schrieb Lukas Wagner: > +fn render_remote_summary_counter(count: u32, task_class: RemoteSummaryIcon) -> Html { > + let (icon_class, icon_scheme, state_text) = match task_class { > + RemoteSummaryIcon::UpToDate => ( > + "check", > + FontColor::Success, > + tr!("One node is up-to-date." | "{n} nodes are up-to-date." % count), > + ), > + RemoteSummaryIcon::Error => ( > + "times-circle", > + FontColor::Error, > + tr!("Failed to retrieve update info for one node." > + | "Failed to retrieve update info for {n} nodes." % count), > + ), > + RemoteSummaryIcon::Updatable => ( > + "refresh", > + FontColor::Primary, > + tr!("One node has updates available." | "{n} nodes have updates available." % count), > + ), > + }; > + > + let icon = Fa::new(icon_class).margin_end(3).class(icon_scheme); > + > + Tooltip::new( > + Container::from_tag("span") > + .with_child(icon) > + .with_child(count) > + .margin_end(5), > + ) > + .tip(state_text) I found the standalone numbers a bit confusing, i.e. interpreted them as "X updates available" at first. As we got the horizontal space, what about moving the state_text out of a tooltip and make it the always visible text? btw. could be nice to show single-node remotes (PBS, single-node PVEs and potentially PMG in the future) directly at the top level, i.e. without a nesting level indirection. That would save a bit vertical space and avoid clicks. Some other things that might not belong to this reply but I noticed: - do we have the last apt update time available? could be nice to show that as column, e.g. colored as warning if it's older than a day or so (but can be added anytime so definitively not a blocker now). - Might be nicer to add the horizontal scrolling to the inner views, as with 1440x900 there are already columns cut-off in the Update List view on the right, and that resolution is definitively one that should still be usable (but doesn't have to look great). - Repo state would be really good to see here, as else one might get a false sense of security/safety if all is green checkmarks, but that then being the result of bad/no repos configured over the system being actually fully up-to-date. Besides the unlabeled number these can all be follow ups (if at all), so I'm fine with applying this as is, but you might have a better gut feeling if it's fine to do follow-ups over a v3, so just tell me what you prefer. > + .into() > +} ... > + fn render_update_list_panel(&self, ctx: &LoadableComponentContext) -> Panel { > + let title: Html = Row::new() > + .gap(2) > + .class(AlignItems::Baseline) > + .with_child(Fa::new("list")) > + .with_child(tr!("Update List")) > + .into(); Might be nice to see the selected nodename in the title, especially with many remotes/nodes and the right list having been scrolled so that the selected one is out of view. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel