From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C14911FF185 for ; Mon, 21 Jul 2025 14:05:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E83CACC1D; Mon, 21 Jul 2025 14:06:29 +0200 (CEST) Message-ID: <4310803a-1e11-4ae3-8ec1-a37101134daf@proxmox.com> Date: Mon, 21 Jul 2025 14:05:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Aaron Lauterer References: <20250715143218.1548306-1-a.lauterer@proxmox.com> <20250715143218.1548306-22-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250715143218.1548306-22-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753099548862 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v3 08/14] ui: add pressure graphs to node and guest summary X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As with the patch before, we might want to refactor the colors somewhere Otherwise: Reviewed-by: Dominik Csapak On 7/15/25 16:32, Aaron Lauterer wrote: > From: Folke Gleumes > > Pressures are indicatios that processes needed to wait for their > resources. While 'some' means, that some of the processes on the host > (node summary) or in the guests cgroup had to wait, 'full' means that > all processes couldn't get the resources fast enough. > > We set the colors accordingly. For 'some' we use yellow, for 'full' we > use red. > This should make it clear that this is not just another graph, but > indicates performance issues. It also sets the pressure graphs apart > from the other graphs that follow the usual color scheme. > > Originally-by: Folke Gleumes > [AL: > * rebased > * reworked commit msg > * set colors > ] > Signed-off-by: Aaron Lauterer > --- > www/manager6/node/Summary.js | 27 +++++++++++++++++++++++++++ > www/manager6/panel/GuestSummary.js | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > > diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js > index ed3d33d9..b00fcf2e 100644 > --- a/www/manager6/node/Summary.js > +++ b/www/manager6/node/Summary.js > @@ -196,6 +196,33 @@ Ext.define('PVE.node.Summary', { > fields: ['netin', 'netout'], > store: rrdstore, > }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('CPU pressure'), > + fieldTitles: ['Some'], > + fields: ['pressurecpusome'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('IO pressure'), > + fieldTitles: ['Some', 'Full'], > + fields: ['pressureiosome', 'pressureiofull'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('Memory pressure'), > + fieldTitles: ['Some', 'Full'], > + fields: ['pressurememorysome', 'pressurememoryfull'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > ], > listeners: { > resize: function (panel) { > diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js > index 5efbe40f..0b62dbb7 100644 > --- a/www/manager6/panel/GuestSummary.js > +++ b/www/manager6/panel/GuestSummary.js > @@ -102,6 +102,36 @@ Ext.define('PVE.guest.Summary', { > fields: ['diskread', 'diskwrite'], > store: rrdstore, > }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('CPU pressure'), > + pveSelNode: me.pveSelNode, > + fieldTitles: ['Some', 'Full'], > + fields: ['pressurecpusome', 'pressurecpufull'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('IO pressure'), > + pveSelNode: me.pveSelNode, > + fieldTitles: ['Some', 'Full'], > + fields: ['pressureiosome', 'pressureiofull'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > + { > + xtype: 'proxmoxRRDChart', > + title: gettext('Memory pressure'), > + pveSelNode: me.pveSelNode, > + fieldTitles: ['Some', 'Full'], > + fields: ['pressurememorysome', 'pressurememoryfull'], > + colors: ['#FFD13E', '#A61120'], > + store: rrdstore, > + unit: 'percent', > + }, > ); > } > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel