Re: [PATCH pve-storage] esxi plugin: keep uuid inside vm the same as in esxi

[Nicolas Reinecke <nr@das-labor.org>]

I signed the CLA already and IT got confirmed on 24. july. Thanks for reviewing.

07.08.2026 14:56:01 Max R. Carrara <m.carrara@proxmox.com>:

> On Mon Jul 27, 2026 at 5:17 PM CEST, Nicolas Reinecke wrote:
>> There needs to be done some byte swapping in the first 3 parts to keep
>> the uuid the same.
>> 
>> RegEx Group Mapping to Bytes:
>> $1-$4 : 1st section (4 bytes) -> Reversed to $4$3$2$1
>> $5-$6 : 2nd section (2 bytes) -> Reversed to $6$5
>> $7-$8 : 3rd section (2 bytes) -> Reversed to $8$7
>> $9    : 4th section (2 bytes) -> Kept as-is
>> $10   : 5th section (6 bytes) -> Kept as-is
>> 
>> Signed-off-by: Nicolas Reinecke <nr@das-labor.org>
> 
> Thanks for your patch! Have you by change filled out a CLA yet?
> If not, see here: https://proxmox.com/en/about/open-source/developers
> 
> Once confirmed that the CLA's in, I'll have a closer look at this.
> 
> - Max
> 
>> ---
>> src/PVE/Storage/ESXiPlugin.pm | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>> 
>> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
>> index 19f23bb..fd0ef0a 100644
>> --- a/src/PVE/Storage/ESXiPlugin.pm
>> +++ b/src/PVE/Storage/ESXiPlugin.pm
>> @@ -1010,14 +1010,19 @@ sub smbios1_uuid {
>> 
>>      if (
>>          $uuid =~ /^
>> -   ([0-9a-fA-F]{8})
>> -   ([0-9a-fA-F]{4})
>> -   ([0-9a-fA-F]{4})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>> +   ([0-9a-fA-F]{2})
>>     ([0-9a-fA-F]{4})
>>     ([0-9a-fA-F]{12})
>>     $/x
>>      ) {
>> -        return "$1-$2-$3-$4-$5";
>> +        return "$4$3$2$1-$6$5-$8$7-$9-$10";
>>      }
>>      return;
>> }