From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C589C1FF17A for ; Tue, 9 Dec 2025 08:59:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 94D001E5A2; Tue, 9 Dec 2025 09:00:04 +0100 (CET) Message-ID: <42197a46-ac7c-4adf-99a4-628cff5c0fb7@proxmox.com> Date: Tue, 9 Dec 2025 08:59:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Dominik Csapak To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20251205143450.2953331-1-d.csapak@proxmox.com> <176494884271.155100.16563011649636460356.b4-ty@proxmox.com> Content-Language: en-US In-Reply-To: <176494884271.155100.16563011649636460356.b4-ty@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765267195442 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] applied: [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 12/5/25 4:34 PM, Thomas Lamprecht wrote: > On Fri, 05 Dec 2025 15:34:45 +0100, Dominik Csapak wrote: >> For some reason, using a space separated list of classes in `itemCls` >> breaks the extjs debug mode. This is seemingly allowed everywhere else, >> so to fix it, simply apply the classes directly to the children >> with 'default'. >> >> > > Applied, thanks! > > [1/1] RRDTypeSelector: fix extjs debug mode > commit: 54a2e4173c47e7891af9cbbbdbf4f976a924fc7c thanks for fixing the type, but sadly it was not complete, see my current patch that fixes it: https://lore.proxmox.com/pve-devel/20251209074037.114475-1-d.csapak@proxmox.com/T/#u to explain how the typo slipped in: usually i stash my changes when testing different things, but in this case i thought the three lines are easy enough to do it fresh, but obviously i didn't retest with the patch i sent so, sorry for the noise and additional work this caused _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel