From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id ED3711FF0AA for ; Tue, 20 Oct 2026 15:36:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 47D05216BA; Tue, 20 Oct 2026 15:36:56 +0200 (CEST) Message-ID: <416ec56f-ebe6-4d62-adb8-b12d0420ffe3@proxmox.com> Date: Tue, 20 Oct 2026 15:36:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-container v3 14/17] net: report NIC plugs and removals to the SDN DHCP backends To: pve-devel@lists.proxmox.com References: <20261020080005.470757-1-h.laimer@proxmox.com> <20261020080005.470757-15-h.laimer@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20261020080005.470757-15-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.347 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FAQTZACA3XVCVFJC3QG6ECYUDU4CYECR X-Message-ID-Hash: FAQTZACA3XVCVFJC3QG6ECYUDU4CYECR X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tested-by: Stefan Hanreich On 10/20/26 10:02 AM, Hannes Laimer wrote: > An SDN DHCP backend answers a guest NIC with the address IPAM holds > for its MAC. A NIC joining its bridge now hands its MAC to the SDN > plug, so the backend of its vnet can answer its first request. > Deleting a veth also reports it as gone to the backends, since their > state for an interface can outlive it. > > On a running container, a bridge change now pushes the DHCP mapping > for the new vnet, as adding a NIC or changing its MAC already does. > > Signed-off-by: Hannes Laimer > --- > src/PVE/LXC.pm | 13 +++++++++++-- > src/PVE/LXC/Config.pm | 3 ++- > src/lxc-pve-poststop-hook | 6 +++--- > 3 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 1f11490..c3cf9e7 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1111,7 +1111,13 @@ sub net_tap_plug : prototype($$) { > my $create_firewall_bridges = $net->{firewall} && PVE::Firewall::Helpers::needs_fwbr($bridge); > > PVE::Network::SDN::Zones::tap_plug( > - $iface, $bridge, $tag, $create_firewall_bridges, $trunks, $rate, > + $iface, > + $bridge, > + $tag, > + $create_firewall_bridges, > + $trunks, > + $rate, > + { mac => $hwaddr }, nit: I understand that this function already has quite a few arguments, but introducing a new $opts and then setting the MAC there seems somewhat awkward as well? A matter of taste though, I suppose.. > ); > PVE::Network::SDN::Zones::add_bridge_fdb($iface, $hwaddr, $bridge); > > @@ -1137,7 +1143,7 @@ sub update_net { > || safe_string_ne($oldnet->{name}, $newnet->{name}) > ) { > > - PVE::Network::veth_delete($veth); > + PVE::Network::SDN::Zones::veth_delete($veth); > > if (safe_string_ne($oldnet->{hwaddr}, $newnet->{hwaddr})) { > eval { > @@ -1192,6 +1198,9 @@ sub update_net { > PVE::Network::SDN::Vnets::add_next_free_cidr( > $newnet->{bridge}, $conf->{hostname}, $newnet->{hwaddr}, $vmid, undef, 1, > ); > + PVE::Network::SDN::Vnets::add_dhcp_mapping( > + $newnet->{bridge}, $newnet->{hwaddr}, $vmid, $conf->{hostname}, > + ); > } > eval { PVE::LXC::net_tap_plug($veth, $newnet) }; > if (my $err = $@) { > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > index 9823d00..b522413 100644 > --- a/src/PVE/LXC/Config.pm > +++ b/src/PVE/LXC/Config.pm > @@ -12,6 +12,7 @@ use PVE::GuestHelpers; > use PVE::INotify; > use PVE::JSONSchema qw(get_standard_option); > use PVE::Network::SDN::Vnets; > +use PVE::Network::SDN::Zones; > use PVE::RESTEnvironment; > use PVE::Tools; > > @@ -1696,7 +1697,7 @@ sub vmconfig_hotplug_pending { > my $net = parse_lxc_network($conf->{$opt}); > PVE::LXC::kill_dhclients($vmid, $net->{name}) if $net->{'host-managed'}; > > - PVE::Network::veth_delete("veth${vmid}i$netid"); > + PVE::Network::SDN::Zones::veth_delete("veth${vmid}i$netid"); > print "delete ips from $opt\n"; > eval { > PVE::Network::SDN::Vnets::del_ips_from_mac( > diff --git a/src/lxc-pve-poststop-hook b/src/lxc-pve-poststop-hook > index c8bbb79..c5d1059 100755 > --- a/src/lxc-pve-poststop-hook > +++ b/src/lxc-pve-poststop-hook > @@ -11,7 +11,7 @@ use PVE::GuestHelpers; > use PVE::LXC::Config; > use PVE::LXC::Tools; > use PVE::LXC; > -use PVE::Network; > +use PVE::Network::SDN::Zones; > use PVE::RESTEnvironment; > use PVE::Storage; > use PVE::Tools; > @@ -49,8 +49,8 @@ PVE::LXC::Tools::lxc_hook( > my $ind = $1; > my $net = PVE::LXC::Config->parse_lxc_network($conf->{$k}); > next if $net->{type} ne 'veth'; > - # veth_delete tests with '-d /sys/class/net/$name' before running the command > - PVE::Network::veth_delete("veth${vmid}i$ind"); > + # reports the unplug and deletes the veth only where it still exists > + PVE::Network::SDN::Zones::veth_delete("veth${vmid}i$ind"); > } > > my $config_updated = 0;