From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9A3F81FF139 for ; Tue, 10 Feb 2026 15:07:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 687163517; Tue, 10 Feb 2026 15:08:10 +0100 (CET) Message-ID: <40ba8a32-f677-4421-9d95-89a80622c62e@proxmox.com> Date: Tue, 10 Feb 2026 15:07:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pbs-devel] [PATCH proxmox v4 2/4] proxmox-access-control: cache verified API token secrets To: Christian Ebner , Proxmox Backup Server development discussion References: <20260121151408.731516-1-s.rufinatscha@proxmox.com> <20260121151408.731516-7-s.rufinatscha@proxmox.com> <50133029-8a66-4ba1-92bc-8695767a83aa@proxmox.com> Content-Language: en-US From: Samuel Rufinatscha In-Reply-To: <50133029-8a66-4ba1-92bc-8695767a83aa@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.262 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 43TF7DU7JROIJYT657TFTYANOAV3X6II X-Message-ID-Hash: 43TF7DU7JROIJYT657TFTYANOAV3X6II X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/10/26 2:36 PM, Christian Ebner wrote: > On 1/21/26 4:13 PM, Samuel Rufinatscha wrote: >> Adds an in-memory cache of successfully verified token secrets. >> Subsequent requests for the same token+secret combination only perform a >> comparison using openssl::memcmp::eq and avoid re-running the password >> hash. The cache is updated when a token secret is set and cleared when a >> token is deleted. >> >> Signed-off-by: Samuel Rufinatscha >> --- > > IMHO the commit message should contain a concise additional statement > specifying the purpose of the shared shadow generation for inter-process > cache invalidation, as the code in this patch covers that to a > significant extend. > > Forgot to mention this on patch 2 for proxmox-backup, where it applies > as well. > Agreed, this should be added and will make the implementation a bit more obvious. Will add also on patch 2, thanks!