From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F8DC622FD; Tue, 29 Sep 2020 18:58:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DEAF11AB3; Tue, 29 Sep 2020 18:58:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 705FD11AA7; Tue, 29 Sep 2020 18:58:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 342614584F; Tue, 29 Sep 2020 18:58:14 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200916121419.3997-1-s.ivanov@proxmox.com> <20200916121419.3997-4-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <40af85cf-81ea-a4aa-4af2-df0830b3980b@proxmox.com> Date: Tue, 29 Sep 2020 18:58:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200916121419.3997-4-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.166 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.pm] Subject: [pve-devel] applied: [RFC storage 1/1] Disks: instantiate import unit for created zpool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 29 Sep 2020 16:58:15 -0000 On 16.09.20 14:14, Stoiko Ivanov wrote: > When creating a new ZFS storage, also instantiate an import-unit for th= e pool. > This should help mitigate the case where some pools don't get imported = during > boot, because they are not listed in an existing zpool.cache file. >=20 > This patch needs the corresponding addition of 'zfs-import@.service' in= > the zfsonlinux repository. >=20 > Suggested-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > PVE/API2/Disks/ZFS.pm | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > applied, thanks! As we have no dependency on zfsutils-linux here to do a bump to the versioned dependency, I added a simple check if the zfs-impor= t@ template service exists (roughly, if -e '/lib/systemd/system/zfs-import@.= service') From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F8DC622FD; Tue, 29 Sep 2020 18:58:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DEAF11AB3; Tue, 29 Sep 2020 18:58:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 705FD11AA7; Tue, 29 Sep 2020 18:58:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 342614584F; Tue, 29 Sep 2020 18:58:14 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com>, pbs-devel@lists.proxmox.com References: <20200916121419.3997-1-s.ivanov@proxmox.com> <20200916121419.3997-4-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <40af85cf-81ea-a4aa-4af2-df0830b3980b@proxmox.com> Date: Tue, 29 Sep 2020 18:58:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200916121419.3997-4-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.166 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.pm] Subject: [pbs-devel] applied: [pve-devel] [RFC storage 1/1] Disks: instantiate import unit for created zpool X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 29 Sep 2020 16:58:15 -0000 On 16.09.20 14:14, Stoiko Ivanov wrote: > When creating a new ZFS storage, also instantiate an import-unit for th= e pool. > This should help mitigate the case where some pools don't get imported = during > boot, because they are not listed in an existing zpool.cache file. >=20 > This patch needs the corresponding addition of 'zfs-import@.service' in= > the zfsonlinux repository. >=20 > Suggested-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > PVE/API2/Disks/ZFS.pm | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > applied, thanks! As we have no dependency on zfsutils-linux here to do a bump to the versioned dependency, I added a simple check if the zfs-impor= t@ template service exists (roughly, if -e '/lib/systemd/system/zfs-import@.= service')