From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 257A77439D for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:22:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BC521A59E for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:22:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 11D721A585 for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:22:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9B33440C70 for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:22:44 +0200 (CEST) Message-ID: <3fd5d90e-1369-618d-5926-6e4ca6ffa186@proxmox.com> Date: Mon, 21 Jun 2021 11:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20210618105938.57107-1-f.ebner@proxmox.com> <20210618105938.57107-7-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210618105938.57107-7-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.719 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH storage 1/2] vdisk_list: only scan storages with the correct content type(s) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 21 Jun 2021 09:22:56 -0000 On 18.06.21 12:59, Fabian Ebner wrote: > The enabled check in the lower loop is now redundant and can be removed. > > If storeid is provided, initialize the result hash accordingly, mainly for > backwards compatibility (needed by a caller in pve-manager's Ceph/Pools.pm and > the migration code in pve-container and qemu-server), but it also is less > surprising in general. > > Remaining vdisk_list users that do not specify a content type are: > 1. pve-manager's Pool/Ceph.pm, but the content type for RBD can only be > rootdir and images, so the storage is scanned (if enabled, same as > before). > 2. pve-container migration > 3. qemu-server migration > For the latter two, it's planned to enforce content type, so the change is fine > too. > > This also means that for iscsi(direct) plugins with content type 'none', i.e. > "use LUNs directly" does not return the list of images anymore, but that was > rather a bug anyways as they're not virtual disks then: > 0.0.0.scsi-36001405b8f2772e13a04b8e9390db13d > All of the remaining callers not using content types (see above) are fine with > that change too. > > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > > Breaks old migration behavior when there are unused/unreferenced/vmstate volumes > on a misconfigured storage! > > PVE/Storage.pm | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > applied, thanks!