From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 85E861FF191 for ; Tue, 4 Nov 2025 09:58:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DE3C77AB; Tue, 4 Nov 2025 09:59:00 +0100 (CET) Message-ID: <3f25e78c-d445-4567-a723-34935a7b0cb8@proxmox.com> Date: Tue, 4 Nov 2025 09:58:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20251104073403.14933-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251104073403.14933-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762246719442 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/4/25 8:34 AM, Hannes Laimer wrote: > There is no reason to still default to only listing pulling jobs. Well, this was overlooked for PBS 4.0, but I'm afraid the change needs to be postponed to PBS version 5.0, as this is a breaking API change. > > Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/ > Signed-off-by: Hannes Laimer > --- > src/api2/admin/sync.rs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs > index 6722ebea..c21a6909 100644 > --- a/src/api2/admin/sync.rs > +++ b/src/api2/admin/sync.rs > @@ -23,18 +23,17 @@ use crate::{ > server::sync::do_sync_job, > }; > > -// FIXME: 4.x make 'all' the default > #[api()] > #[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)] > #[serde(rename_all = "kebab-case")] > /// The direction of the listed sync jobs: push, pull or all. > pub enum ListSyncDirection { > /// All directions > + #[default] > All, > /// Sync direction push > Push, > /// Sync direction pull > - #[default] > Pull, > } > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel