From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CB9E91FF0E9 for ; Thu, 16 Jul 2026 14:50:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2FF2621418; Thu, 16 Jul 2026 14:50:11 +0200 (CEST) Message-ID: <3f04e2b9-d39f-4604-b169-c3ae530256af@proxmox.com> Date: Thu, 16 Jul 2026 14:50:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH cluster 2/2] fix #5475: configurable window title To: Thomas Ellmenreich , pve-devel@lists.proxmox.com References: <20260716084807.77400-1-t.ellmenreich@proxmox.com> <20260716084807.77400-3-t.ellmenreich@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260716084807.77400-3-t.ellmenreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784206188042 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.236 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GKZT72C6ZKIXFJ6UZHO6FBC5GBKA7ZRZ X-Message-ID-Hash: GKZT72C6ZKIXFJ6UZHO6FBC5GBKA7ZRZ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 16.07.26 um 10:49 schrieb Thomas Ellmenreich: > Added new configuration option that will determine the content > of the window title for a pve-manager tab. > > Signed-off-by: Thomas Ellmenreich > --- > src/PVE/DataCenterConfig.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..6f3f482 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -436,6 +436,13 @@ my $datacenter_schema = { > # FIXME: remove 'applet' with 9.0 (add pve8to9 check!) > enum => ['applet', 'vv', 'html5', 'xtermjs'], > }, > + 'window-title' => { > + optional => 1, > + type => 'string', > + description => > + "Define the text shown in the window title for all nodes of this cluster", > + enum => ['node-and-cluster', 'fqdn'], > + }, The window term is a bit opaque here in the backend, but can be fine.. Would favor using a format here from the start to make this easier to expand, e.g. I could imagine adding support for passing a color that gets rendered in the favicon e.g. as circle or corner for some differentiating from that side, or a prefix/suffix added to the title. Needs more thought, and we can expand such things later true our default-key schema support, but might be nicer to start out already with a format now already. we could do a more general "ui" or "ui-settings" one to see this from a global UI settings POV? and then there simply "title" or as property. > email_from => { > optional => 1, > type => 'string',