From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 768A11FF17C for ; Tue, 16 Dec 2025 13:14:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E3981DA63; Tue, 16 Dec 2025 13:15:02 +0100 (CET) Message-ID: <3ef61f79-998e-46a1-ba14-ca4277ff482c@proxmox.com> Date: Tue, 16 Dec 2025 13:14:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Maximiliano Sandoval References: <20251212130531.116019-1-d.rusovac@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765887291740 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager] fix #7011: ceph monitor: set ownership of monitor logs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Dominik Rusovac Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 16.12.25 um 13:06 schrieb Maximiliano Sandoval: > Thomas Lamprecht writes: > >> Am 12.12.25 um 14:05 schrieb Dominik Rusovac: >>> Ownership of ceph logs is now set to ceph:ceph after the creation of a >>> new monitor and before the new monitor starts. Hence, effective ceph >>> monitor logging on freshly set up ceph clusters no longer depends on the >>> first upgrade of ceph-common. >> >> Might it be a better fix to then change the postinst script of >> ceph-common, or whatever packages postinst script creates those >> directories, to chown them to ceph:ceph? That way it would also work >> if one installs ceph directly, circumventing pveceph. While that is >> not exactly something we promote, but it's not really hard, and >> packaging is often a good place to take care of such things like >> directory ownership > > The directories are created with the right permissions and owner, the > issue here is that the monitor logs generated when we create the monitor > (the command above the call introduced by the patch) are created with > root as the owner. > Ok, thanks for your input, I missed your other reply due to searching explicitly for Dominik's patch due to talking with him in the morning. Anyhow, then I'd favor addressing the actual root cause in the "ceph-mon --mkfs" command over this approach here, might not be that complicated - I'm sure Max might have some pointers or could help, having wrestled with the ceph tooling in the past. Again, something like that here can still be fine as stop-gap, but then I really would use chown function inside a call to dir_glob_regex from PVE::Tools. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel