From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B4B4A1FF187 for ; Fri, 2 Jan 2026 11:09:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0E9C8754; Fri, 2 Jan 2026 11:10:42 +0100 (CET) Message-ID: <3ee571a2-b08d-4214-a6d3-7cb47295d7ea@proxmox.com> Date: Fri, 2 Jan 2026 11:10:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maximiliano Sandoval References: <20251014122718.374205-1-m.sandoval@proxmox.com> <20251014122718.374205-5-m.sandoval@proxmox.com> <4a946522-661c-4cd5-adbf-b122b0b4eb0e@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767348608878 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v3 4/7] log when issuing a guest-fsfreeze command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.12.25 um 4:32 PM schrieb Maximiliano Sandoval: > Fiona Ebner writes: > >> Am 14.10.25 um 2:27 PM schrieb Maximiliano Sandoval: >>> These messages appear during replication or snapshots. >>> >>> The messages will now appear on all call sites of __snapshot_freeze(). >>> >>> Signed-off-by: Maximiliano Sandoval >>> --- >>> src/PVE/QemuConfig.pm | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm >>> index 412c76ae..32a95dd6 100644 >>> --- a/src/PVE/QemuConfig.pm >>> +++ b/src/PVE/QemuConfig.pm >>> @@ -310,9 +310,11 @@ sub __snapshot_freeze { >>> my ($class, $vmid, $unfreeze) = @_; >>> >>> if ($unfreeze) { >>> + print "issuing guest agent 'guest-fsfreeze-thaw' command\n"; >>> eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); }; >>> warn "guest-fsfreeze-thaw problems - $@" if $@; >>> } else { >>> + print "issuing guest agent 'guest-fsfreeze-freeze' command\n"; >>> eval { PVE::QemuServer::Agent::guest_fsfreeze($vmid); }; >>> warn $@ if $@; >>> } >> >> Maybe there should be a PVE::QemuServer::Agent::guest_fsthaw() helper >> and the messages should go into the Agent::guest_fs{freeze,thaw}() >> helpers directly rather than on all call sites. Avoids duplication and >> improves consistency. > > The problem is that half of the users would prefer to log with a logging > function, adding a `$logfunc` parameter to these two helpers can be OK, > but it also requires changes in LXC.pm. As discussed off-list, the complication here is the caller of __snapshot_freeze in pve-guest-common/Replication.pm which uses a dedicated $logfunc which would need to be passed along. I wasn't aware of this when proposing the change, so please just go ahead with the rest :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel