From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3328F62F34 for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 16:26:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2918E249BB for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 16:26:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B6F6E249B1 for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 16:26:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7B9AB45585 for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 16:26:06 +0100 (CET) Message-ID: <3e2870df-22e7-5fe2-d0f5-681e52ad8741@proxmox.com> Date: Mon, 8 Feb 2021 16:26:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20210208142603.24149-1-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210208142603.24149-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] test: migrate: correctly mock storage module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 08 Feb 2021 15:26:07 -0000 On 08.02.21 15:26, Fabian Ebner wrote: > by fixing a typo. Since cfs_read_file within the storage module was not= mocked, > the tests could fail on some setups. Now that get_bandwidth_limit is mo= cked, > cfs_read_file is not called anymore, but still mock it too for good mea= sure and > to make it more future-proof. >=20 > Reported-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com> > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > test/MigrationTest/Shared.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > applied, thanks!