Re: [PATCH yew-comp] wizard: fix page unlocking with advanced fields

[Dominik Csapak <d.csapak@proxmox.com>]

On 5/28/26 12:20 PM, Thomas Lamprecht wrote:
> Am 28.05.26 um 11:18 schrieb Dominik Csapak:
>> The wizard depends on the form context validation of the pages to
>> determine which to lock and unlock. Initially all pages are locked and
>> only if the form_ctx changes and is valid the corresponding page will be
>> unlocked. With the introduction of the advanced button in the wizard,
>> this can happen for pages even if they're not rendered yet.
> 
> I.e., pages get unlocked overly eagerly vs. kept beeing locked? Just to be
> sure as the subject confused me there for a moment.

yes exactly, when the page is not rendered yet, the form_ctx does not
have any registered fields and the advanced cb change triggers the
form_ctx change and at this point the page is 'valid'.

> Maybe "fix page validation with advanced fields" as that's what's fixed,
> the unlocking is then just an effect of that (can edit that on applying).

yes that's fine with me, should i send a v2 or is it fine to simply
fix it up on applying?

> 
> FWIW, for the auto installer answer file wizard I'd like to add a
> "free_navigation" option to the wizard, with that then one can navigate
> through all steps freely from the start. Needs validity handling on submit
> and a small UI hint for invalid tabs in the bar for UX though, which is a bit
> more work and that's why I skipped adding it yesterday.

maybe then a wizard is not actually what we want here, but maybe a
manual tabpanel which marks the tabs with a fa-triangle-exclamation
or something if it's not valid?

> 
> Just mentioning for context, your patch here is still warranted in any case.