From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BE44A1FF144 for ; Tue, 10 Mar 2026 18:09:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 543FC6556; Tue, 10 Mar 2026 18:09:14 +0100 (CET) Message-ID: <3dcccf14-6adf-4367-b46d-9a14ba15339d@proxmox.com> Date: Tue, 10 Mar 2026 18:09:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 proxmox-backup 2/3] api: backup: improve schema documentation of fixed_close To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260310160537.182153-1-r.obkircher@proxmox.com> <20260310160537.182153-3-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260310160537.182153-3-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773162516536 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5MN6MAO7HZYJKHUGPMCIHKE3CW2LRG5G X-Message-ID-Hash: 5MN6MAO7HZYJKHUGPMCIHKE3CW2LRG5G X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/10/26 5:08 PM, Robert Obkircher wrote: > The chunk-count has always been compared to the number of digests > written to the fixed index file. It was never ignored. > > Signed-off-by: Robert Obkircher > --- > src/api2/backup/mod.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs > index 4d0846ca..3c044c78 100644 > --- a/src/api2/backup/mod.rs > +++ b/src/api2/backup/mod.rs > @@ -765,7 +765,7 @@ pub const API_METHOD_CLOSE_FIXED_INDEX: ApiMethod = ApiMethod::new( > ( > "chunk-count", > false, > - &IntegerSchema::new("Chunk count. This is used to verify that the server got all chunks. Ignored for incremental backups.") > + &IntegerSchema::new("Chunk count. This is used to verify that the server got all chunks.") This should probably state that this is the count of new and/or re-indexed chunks. That is true for both incremental and non-incremental backups. It is however not always the total chunk count of the index file, which is only checked if this is not an incremental backup. > .minimum(0) > .schema() > ),