From: Dominik Csapak <d.csapak@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: sdn: use unicode characters for le and ge
Date: Fri, 12 Jun 2026 10:57:54 +0200 [thread overview]
Message-ID: <3c5f2541-e0d2-4a3c-ae4d-2bb305ade73c@proxmox.com> (raw)
In-Reply-To: <DJ6BKP7CS1VZ.1E4FBTU8LXGDM@proxmox.com>
On 6/11/26 5:18 PM, Shannon Sterz wrote:
> On Thu Jun 11, 2026 at 4:28 PM CEST, Gabriel Goller wrote:
>> Not sure what our stance on this is, I couldn't find any occurence of ≤ or ≥
>> with a quick grep in our repos, so this is probably a first.
>>
>> From my side:
>> Acked-by: Gabriel Goller <g.goller@proxmox.com>
>>
>> Maybe @Shannon or @Dominik have a strong opinion on this?
>
> Hm not really, the only concern id have is maybe a users does not have
> those glyphs in a local sans-serif font and then this could get rendered
> as "tofu" [1]. Having said that, these glyphs are probably pretty common
> at this point, so it should be fine.
>
> Note that this could also be mitigated by us shipping a font that
> supports those glyphs. We currently aren't doing that to my knowledge.
>
> [1]: https://en.wikipedia.org/wiki/Specials_(Unicode_block)#Replacement_character
also don't have a super strong opinion on that, but IMO the bigger
question here is: why should we change the status quo?
What is the actual improvement here?
@Maximiliano: the commit message could include a 'why'.
I don't think it'll make much difference for the end-users (at least
I can't remember any bug reports for it) but it will "break" all
translations temporarily until each language is updated again.
So while it might look a bit nicer, i don't think we gain much here.
prev parent reply other threads:[~2026-06-12 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 13:40 [PATCH manager] ui: sdn: use unicode characters for le and ge Maximiliano Sandoval
2026-06-11 14:28 ` Gabriel Goller
2026-06-11 15:19 ` Shannon Sterz
2026-06-12 8:57 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c5f2541-e0d2-4a3c-ae4d-2bb305ade73c@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.