From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1713A1FF13A for ; Wed, 29 Apr 2026 13:05:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E646B2376; Wed, 29 Apr 2026 13:05:21 +0200 (CEST) Message-ID: <3c148d5c-64db-4908-aef4-701497486558@proxmox.com> Date: Wed, 29 Apr 2026 13:04:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH widget-toolkit] confirm remove dialog: improve layout for larger fields/components To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20260429101328.1651618-1-d.csapak@proxmox.com> Content-Language: en-US From: Samuel Rufinatscha In-Reply-To: <20260429101328.1651618-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.226 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: STI6IO4VMROZ7UTSZBIXGLVKKW3A23TY X-Message-ID-Hash: STI6IO4VMROZ7UTSZBIXGLVKKW3A23TY X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/29/26 12:11 PM, Dominik Csapak wrote: > If there are larger fields e.g. in the additionalItems property, the > current layout configuration leads to cut-off text and fields. > > To fix this, apply 'flex: 1' to the overall body and actual content > component (so they adapt their size) and use 'align: stretch' for the > content vbox (so the elements adapt to the size of the other content > elements). > > with that, these larger elements (e.g. a hint box) will either shrink, > or wrap it's text. > > Signed-off-by: Dominik Csapak > --- > src/window/ConfirmRemoveDialog.js | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/window/ConfirmRemoveDialog.js b/src/window/ConfirmRemoveDialog.js > index 94f1e84..5f76e47 100644 > --- a/src/window/ConfirmRemoveDialog.js > +++ b/src/window/ConfirmRemoveDialog.js > @@ -133,6 +133,7 @@ Ext.define('Proxmox.window.ConfirmRemoveDialog', { > } > > let body = { > + flex: 1, > xtype: 'container', > layout: 'hbox', > items: [ > @@ -149,8 +150,12 @@ Ext.define('Proxmox.window.ConfirmRemoveDialog', { > } > > let content = { > + flex: 1, > xtype: 'container', > - layout: 'vbox', > + layout: { > + type: 'vbox', > + align: 'stretch', > + }, > items: [ > { > xtype: 'component', Thanks for the patch, I tested it and it fixes the mentioned issue! Reviewed-by: Samuel Rufinatscha Tested-by: Samuel Rufinatscha