From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 5BBDF1FF0ED
	for <inbox@lore.proxmox.com>; Fri, 31 Jul 2026 12:13:54 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 15D4521472;
	Fri, 31 Jul 2026 12:13:54 +0200 (CEST)
Message-ID: <3c0f6e32-e6d4-4ef5-a550-88ef354dd6a3@proxmox.com>
Date: Fri, 31 Jul 2026 12:13:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH qemu-server 2/2] use new classify_volume_id subroutine
To: Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20260728122218.202963-1-t.ellmenreich@proxmox.com>
 <20260728122218.202963-3-t.ellmenreich@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260728122218.202963-3-t.ellmenreich@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1785492821997
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.155 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 7TALY6WCKELOUWFPN6IHQBJWPK5FIX7I
X-Message-ID-Hash: 7TALY6WCKELOUWFPN6IHQBJWPK5FIX7I
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 28.07.26 um 2:22 PM schrieb Thomas Ellmenreich:
> @@ -766,6 +767,11 @@ sub drive_is_cdrom {
>      return $drive && $drive->{media} && ($drive->{media} eq 'cdrom');
>  }
>  
> +sub drive_is_absolute_path {

Nit: I'd prefer drive_has_absolute_path

> +    my ($drive) = @_;
> +    return PVE::Storage::classify_volume_id($drive->{file}, 1) eq $PVE::Storage::VOL_ABSOLUTE;
> +}
> +
>  sub parse_drive_interface {
>      my ($key) = @_;
>