Re: [PATCH storage v3 1/2] fix #7339: lvmthick: add worker to free space of to be deleted VMs

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 06.05.26 um 12:10 schrieb Friedrich Weber:
> On 06/05/2026 11:57, Lukas Sichert wrote:
>> On 2026-05-05 17:59, Friedrich Weber <f.weber@proxmox.com> wrote:

...

>> That said, this is also suboptimal because if other plugins return
>> worker tasks from their '$free_image' implementations, then their
>> descriptions could also be altered if these flags are set. In the
>> default Proxmox stack this is currently not the case, but it could
>> affect external plugins.

Yeah, this is IMO not really the right level for this. I.e., some
storage specific edge case in the generic plugin storage interface.

>> Another option would be to rename the displayed name for an 'imgdel'
>> task in the UI to 'Destroy image'. That would fit the generic worker
>> task better and would also make the naming consistent with
>> 'unknownimgdel', which is currently displayed as
>> 'Destroy image from unknown guest'.
> 
> Yeah, changing the GUI description of 'imgdel' like that could be an
> option! Though of course there is also some confusion potential there,
> especially for users who upgrade.

FWIW, I also think that it's not perfect, but at least much simpler
and doesn't changes/adds any worker task type, and in addition to that
the respective storage plugins could do a worker task log with such
info in higher detail.

> 
> What do others think?
> 
>>
>> Does anybody have opinions on how to go forward with this?

See above, the approach here breaks abstraction boundaries, so IMO
not acceptable for the ROI we get, so would rather live with the
tradeoffs of the UI + task log solution over this.