From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C9D18909B4
for <pve-devel@lists.proxmox.com>; Mon, 30 Jan 2023 09:04:14 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B31C1C3CC
for <pve-devel@lists.proxmox.com>; Mon, 30 Jan 2023 09:04:14 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 30 Jan 2023 09:04:14 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 046C445186;
Mon, 30 Jan 2023 09:04:14 +0100 (CET)
Message-ID: <39a1904a-e746-b1b3-0836-cf47945168c2@proxmox.com>
Date: Mon, 30 Jan 2023 09:04:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.6.0
Content-Language: en-US
To: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>,
"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"aderumier@odiso.com" <aderumier@odiso.com>
References: <20230104064303.2898194-1-aderumier@odiso.com>
<20230104064303.2898194-6-aderumier@odiso.com>
<432de08a-80af-a9ba-58e9-6edc5d705b97@proxmox.com>
<a5e100572a8143f6b04e764a43b45890575e2668.camel@groupe-cyllene.com>
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <a5e100572a8143f6b04e764a43b45890575e2668.camel@groupe-cyllene.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.043 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.09 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 qemu-server 5/9] memory: get_max_mem: use
config memory max
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2023 08:04:14 -0000
Am 27.01.23 um 16:15 schrieb DERUMIER, Alexandre:
> Le mardi 24 janvier 2023 à 14:05 +0100, Fiona Ebner a écrit :
>>> +my $check_memory_param = sub {
>>> + my ($conf, $param) = @_;
>>> +
>>> + my $mem = parse_memory($param->{memory});
>>> + my $host_max_mem = get_host_max_mem($conf);
>>> +
>>> + if ($mem->{max}) {
>>> + die "memory max can't be bigger than supported cpu
>>> architecture $host_max_mem MB\n"
>>
>> s/MB/MiB
>>
>>> + if $mem->{max} > $host_max_mem;
>>
>> Style nit: you could && both conditions to save lines
>>
>> This could be part of the verifier sub suggested in the last patch
>
> I'm not sure we can use the verifier here,
>
> as we need to retrieve $host_max_mem from the current configuration
> with get_host_max_mem($conf).
You're right, I missed that.
>
>
> This current $check_memory_param, in API2::Qemu , it's done in
> $updatefn, after the lock on the config.
>
>
>