From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 895BD6BCEB for <pve-devel@lists.proxmox.com>; Fri, 19 Feb 2021 17:32:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D3801B5B8 for <pve-devel@lists.proxmox.com>; Fri, 19 Feb 2021 17:32:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 686B21B5A8 for <pve-devel@lists.proxmox.com>; Fri, 19 Feb 2021 17:32:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 375A64497C for <pve-devel@lists.proxmox.com>; Fri, 19 Feb 2021 17:32:38 +0100 (CET) Message-ID: <38976d6c-942e-b4e1-c70e-92c2fdef0211@proxmox.com> Date: Fri, 19 Feb 2021 17:32:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Aaron Lauterer <a.lauterer@proxmox.com> References: <20210212155751.16045-1-a.lauterer@proxmox.com> <20210212155751.16045-5-a.lauterer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210212155751.16045-5-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v2 manager 4/4] ui: qemu/HardwareView: fix CDRom permission checkss X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 19 Feb 2021 16:32:39 -0000 On 12.02.21 16:57, Aaron Lauterer wrote: > There are several types of drives that use the same config keys. Most > notably CDRom and regular VM disks (EFI and cloudinit exist as well). > > Since there is a dedicated permission for CDRom drives we need to check > permissions in more detail, depending on what type of drive it actually > is for things like the edit, remove and Add -> CDRom buttons. > > The permission check in the row definition itself which only checked for > 'VM.Config.Disk' permissions (never_delete) had to be removed and finer > grained checks added for the individual buttons. This also meant a bit > of reshuffling in the checks what kind of disk the current one is. > > Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> > --- > > v2: improved permission checks in the GUI to make sure that CDRom things > will behave as expected and the other things are kept as is. Meaning all > other disks (cloudinit, efi, used, unused) still need VM.Config.Disk > permissions. > > Tested by giving a user only VMAudit and Config.CDRom permissions in the > one case, and all VM.Config.* permissions except CDRom. > > www/manager6/qemu/HardwareView.js | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > applied, but prefixed with some further cleanups which result was merged into this one, so maybe a re-check would be good. much thanks!