From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4494B1FF390 for ; Fri, 24 May 2024 08:57:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D5EB3860; Fri, 24 May 2024 08:57:32 +0200 (CEST) Message-ID: <3799bdc1-3168-4708-8a1e-83388b4b6edd@proxmox.com> Date: Fri, 24 May 2024 08:57:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dominik Csapak , Proxmox Backup Server development discussion References: <20240514103421.289431-1-c.ebner@proxmox.com> <20240514103421.289431-43-c.ebner@proxmox.com> <7a285e31-7483-4840-8b50-f5655fc97a64@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <7a285e31-7483-4840-8b50-f5655fc97a64@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v6 proxmox-backup 42/65] client: streams: add channels for dynamic entry injection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 5/22/24 11:56, Dominik Csapak wrote: > high level: > > i think this patch would be much cleaner if the 57/65 > datastore:chunker: add Chunker trait > > would come before this, because you change stuff around only to change > it again > in a way that could be written better if those patches were > > reversed, e.g. > > in case there was a next_boundary in the ChunkStream, in the final code > there is the same code from the regulary chunking duplicated > > (this.buffer.split_to;this.consumed +=;this.scan_pos) > > and could be trivially handled by the same code part > (with a bit of reordering) > > but the patches in this order make it hard to see since > here the paths are different enough so they can't be shared Okay, will see what to do about this. The motivation for keeping the Chunker trait later in the series was (apart from it having been implemented as followup after being suggested by Fabian) that the dedicated payload chunker might not be accepted/applied, therefore rendering the trait useless. Therefore, I tried to decouple this a bit. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel