From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4081E1FF144 for ; Tue, 10 Mar 2026 18:35:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CC016DDA; Tue, 10 Mar 2026 18:35:28 +0100 (CET) Message-ID: <3788bc07-64bd-42f7-9528-ec4a9186b5d8@proxmox.com> Date: Tue, 10 Mar 2026 18:34:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260310160537.182153-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260310160537.182153-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773164059877 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GY2LOCWL62COMOLLOXC4GN253EYUUFOM X-Message-ID-Hash: GY2LOCWL62COMOLLOXC4GN253EYUUFOM X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/10/26 5:08 PM, Robert Obkircher wrote: > Fix a bug, improve api docs, and disallow API usage that we don't need. > > Robert Obkircher (3): > api: backup: don't verify total file size for incremental backups > api: backup: improve schema documentation of fixed_close > api: backup: disallow incremental backups with different index length > > src/api2/backup/environment.rs | 14 +++++++------- > src/api2/backup/mod.rs | 15 ++++++++++++++- > 2 files changed, 21 insertions(+), 8 deletions(-) > Thanks for the quick fix and sorry that this slipped trough during review/testing. Also can confirm that this fixes the incremental backups with dirty bitmap tracking as used by proxmox-backup-qemu. Tested new and incremental VM backup. Confirmed streaming backup inputs via /dev/stdin still works as expected, also when done incrementally. Reviewed-by: Christian Ebner Tested-by: Christian Ebner