From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EC5E91FF137 for ; Tue, 17 Feb 2026 10:13:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC29F30698; Tue, 17 Feb 2026 10:13:56 +0100 (CET) Message-ID: <376f156b-4343-4be4-8653-2b58fff4abd0@proxmox.com> Date: Tue, 17 Feb 2026 10:13:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 proxmox-backup 07/18] datastore: verify that chunk_size is a power of two To: pbs-devel@lists.proxmox.com References: <20260210150642.469670-1-r.obkircher@proxmox.com> <20260210150642.469670-8-r.obkircher@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <20260210150642.469670-8-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771319596491 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UYU7GG6H6CSFRF5M7UB5CFNOGN6H3R4A X-Message-ID-Hash: UYU7GG6H6CSFRF5M7UB5CFNOGN6H3R4A X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/10/26 16:05, Robert Obkircher wrote: > Guarantee that the bitmasks used to compute the modulo actually yield > the correct value and implicitly guard against divisions by zero. The bitmask trick for faster modulo operations is used by the Reader [1] and Writer [2]. [1] https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-datastore/src/fixed_index.rs;h=6c3be2d492d3b15a04b2d4356d7183d75c349f26;hb=HEAD#l210 [2] https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-datastore/src/fixed_index.rs;h=6c3be2d492d3b15a04b2d4356d7183d75c349f26;hb=HEAD#l380 [..]