From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6C7651FF13A for ; Wed, 13 May 2026 12:22:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABACD750F; Wed, 13 May 2026 12:22:50 +0200 (CEST) Message-ID: <36ef4020-1b61-4dbf-81fa-dbb2a7649a5a@proxmox.com> Date: Wed, 13 May 2026 12:22:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-guest-common 1/3] fix #5713: vzdump: add notification-mode none To: Erik Fastermann , pve-devel@lists.proxmox.com References: <20260513072756.33226-1-e.fastermann@proxmox.com> <20260513072756.33226-2-e.fastermann@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: <20260513072756.33226-2-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778667649521 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.311 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [common.pm] Message-ID-Hash: TWOOQEA2V6FHDSX3B4KPE4RNA3YTCNM6 X-Message-ID-Hash: TWOOQEA2V6FHDSX3B4KPE4RNA3YTCNM6 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Small typo in the description. On 5/13/26 9:26 AM, Erik Fastermann wrote: > Optionally disable sending notification mails with the new option > none for notification-mode in vzdump. > > This can be useful if you want to disable sending notifications for a > specific backup job and not change the global notification settings or > use the deprecated legacy sendmail with an empty address. > > Signed-off-by: Erik Fastermann > --- > src/PVE/VZDump/Common.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index 67a4cf4..1c636b4 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -261,9 +261,10 @@ my $confdesc = { > . " specified address(es) via the 'sendmail' command. If set to 'notification-system'," > . " a notification will be sent via PVE's notification system, and the mailto and" > . " mailnotification will be ignored. If set to 'auto' (default setting), an email will" > - . " be sent if mailto is set, and the notification system will be used if not.", > + . " be sent if mailto is set, and the notification system will be used if not." > + . " If set to 'none', no notification will be send.", should be "sent" instead of "send". > optional => 1, > - enum => ['auto', 'legacy-sendmail', 'notification-system'], > + enum => ['auto', 'legacy-sendmail', 'notification-system', 'none'], > default => 'auto', > }, > tmpdir => {