From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 48ECB601D7
 for <pbs-devel@lists.proxmox.com>; Fri, 16 Oct 2020 10:46:45 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4611518E8E
 for <pbs-devel@lists.proxmox.com>; Fri, 16 Oct 2020 10:46:15 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 479C618E7F
 for <pbs-devel@lists.proxmox.com>; Fri, 16 Oct 2020 10:46:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1365B45CD6
 for <pbs-devel@lists.proxmox.com>; Fri, 16 Oct 2020 10:46:14 +0200 (CEST)
To: Dietmar Maurer <dietmar@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20201015154919.19776-1-t.lamprecht@proxmox.com>
 <20201015154919.19776-4-t.lamprecht@proxmox.com>
 <1026037426.303.1602837870447@webmail.proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <36df6a9b-2b64-241c-ba6e-6acb08ef9219@proxmox.com>
Date: Fri, 16 Oct 2020 10:46:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101
 Thunderbird/82.0
MIME-Version: 1.0
In-Reply-To: <1026037426.303.1602837870447@webmail.proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.378 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.019 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH backup 3/4] tools: file logger: use option
 struct to control behavior
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 16 Oct 2020 08:46:45 -0000

On 16.10.20 10:44, Dietmar Maurer wrote:
> 
>> -        let line = format!("{}: {}\n", rfc3339, msg);
>> +        let line = if self.options.prefix_time {
>> +            format!("{}: {}\n", rfc3339, msg)
>> +        } else {
>> +            format!("{}\n", msg)
>> +        };
> 
> This breaks the build (there is no prefix-time)
> 
> error[E0609]: no field `prefix_time` on type `tools::file_logger::FileLogOptions`
>   --> src/tools/file_logger.rs:67:36
>    |
> 67 |         let line = if self.options.prefix_time {
>    |                                    ^^^^^^^^^^^ unknown field
>    |
>    = note: available fields are: `to_stdout`
> 
> error: aborting due to previous error
> 

argh, sorry, to much git rebasing :(
I'll send a v2