From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.reiter@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A954A6AD66 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:47:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C07B20223 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:47:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 33F9D20216 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:47:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EAA084180E for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:47:41 +0100 (CET) To: Dietmar Maurer <dietmar@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20210216170710.31767-1-s.reiter@proxmox.com> <20210216170710.31767-10-s.reiter@proxmox.com> <1667517314.3028.1613544553823@webmail.proxmox.com> <62011626-da51-ed12-d405-4274eb8ab71d@proxmox.com> <1764987944.3055.1613551813740@webmail.proxmox.com> From: Stefan Reiter <s.reiter@proxmox.com> Message-ID: <36700d15-de59-2a67-397c-f93243d53509@proxmox.com> Date: Wed, 17 Feb 2021 10:47:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1764987944.3055.1613551813740@webmail.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 09/22] client: extract common functions to proxmox_client_tools module X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 17 Feb 2021 09:47:42 -0000 On 17/02/2021 09:50, Dietmar Maurer wrote: > >> On 02/17/2021 8:58 AM Stefan Reiter <s.reiter@proxmox.com> wrote: >> >> >> On 17/02/2021 07:49, Dietmar Maurer wrote: >>> I thought we can put all client related code into src/client/ >>> >>> So why starting another lib inside src/bin/proxmox_client_tools/? >>> >> >> Why was (part of) it initially in src/bin/proxmox_backup_client then and >> not src/client/ ? I thought it was to seperate the "binary-specific" >> client code from more generic client code (such as used in pull or the >> QEMU library as well). > > Ok, but why do you move cli functions like: > > fn paper_key() > fn show_key() > > > Those belongs to proxmox-backup-client - or do we reuse them somewhere? > No, those just slipped in. I'll leave them and also make the rename a seperate commit for a v2.