From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 40A641FF13F for ; Thu, 07 May 2026 14:06:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F1D71738F; Thu, 7 May 2026 14:06:51 +0200 (CEST) Message-ID: <35ca365f-41fc-468a-b9a0-b5198569a6a4@proxmox.com> Date: Thu, 7 May 2026 14:06:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v4 05/17] cpu config: add helpers to lock and write config To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260430160109.565536-1-a.bied-charreton@proxmox.com> <20260430160109.565536-6-a.bied-charreton@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260430160109.565536-6-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778155465893 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 74C2EA4URNWCPBX4BEFY36AUL3QJQFAP X-Message-ID-Hash: 74C2EA4URNWCPBX4BEFY36AUL3QJQFAP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 30.04.26 um 6:01 PM schrieb Arthur Bied-Charreton: > Add lock/write primitives to allow programmatic access to > /etc/pve/virtual-guest/cpu-models.conf as a preparatory step for adding a > custom CPU models CRUD API to pve-manager. > > Signed-off-by: Arthur Bied-Charreton > --- > src/PVE/QemuServer/CPUConfig.pm | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm > index 0ee9b991..65ced94f 100644 > --- a/src/PVE/QemuServer/CPUConfig.pm > +++ b/src/PVE/QemuServer/CPUConfig.pm > @@ -6,7 +6,7 @@ use warnings; > use JSON; > > use PVE::JSONSchema qw(json_bool); > -use PVE::Cluster qw(cfs_register_file cfs_read_file); > +use PVE::Cluster qw(cfs_register_file cfs_read_file cfs_lock_file cfs_write_file); > use PVE::ProcFSTools; > use PVE::RESTEnvironment qw(log_warn); > use PVE::Tools qw(run_command); > @@ -50,6 +50,17 @@ sub load_custom_model_conf { > return cfs_read_file($cpu_models_filename); > } > > +sub write_custom_model_conf { > + my ($conf) = @_; > + cfs_write_file($cpu_models_filename, $conf); > +} > + > +sub lock_cpu_config { I'd prefer lock_custom_model_conf() to be in-line with the others. Or even go for *_custom_cpu_model_config(). AFAICT load_custom_model_conf() is not yet used outside of qemu-server before your series, so can also be adapted rather easily. > + my ($code) = @_; > + cfs_lock_file($cpu_models_filename, undef, $code); > + die $@ if $@; > +} > + > #builtin models : reported-model is mandatory > my $builtin_models_by_arch = { > x86_64 => {