From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 163EE8E5CE for <pve-devel@lists.proxmox.com>; Fri, 11 Nov 2022 19:27:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDAE36A78 for <pve-devel@lists.proxmox.com>; Fri, 11 Nov 2022 19:27:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 11 Nov 2022 19:27:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3D94043AD3 for <pve-devel@lists.proxmox.com>; Fri, 11 Nov 2022 19:27:26 +0100 (CET) Message-ID: <356d914a-1ec4-a0d2-4c0d-bc0fcbe936d4@proxmox.com> Date: Fri, 11 Nov 2022 19:27:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Mira Limbeck <m.limbeck@proxmox.com> References: <20221111154635.394997-1-m.limbeck@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20221111154635.394997-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuconfig.pm] Subject: [pve-devel] applied: [PATCH v3 qemu-server] fix #4201: delete cloud-init disk on rollback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 11 Nov 2022 18:27:27 -0000 Am 11/11/2022 um 16:46 schrieb Mira Limbeck: > If the config doesn't contain the cloud-init disk anymore after the > rollback, we have to clean it up since otherwise no further disk can be > attached unless the one still existing on the storage is deleted. > > Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com> > Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com> > Tested-by: Stefan Hanreich <s.hanreich@proxmox.com> > --- > v3: > - rebased on top of master > - added R-b/T-b tags from v2 > v2: > - chose the add_unused_volume way as @fiona recommended, the > implementation is a lot cleaner, but contains a cloudinit regex > > - removed the 2nd patch for reusing already existing disks when > adding a cloudinit disk > > PVE/QemuConfig.pm | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > applied, thanks to both of you!